New issue
Advanced search Search tips

Issue 688776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

[DevTools] restore provisional breakpoints smarter

Project Member Reported by kozyatinskiy@chromium.org, Feb 5 2017

Issue description

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/497dff7809901ac3319c01fb2f28ad807b708be5

commit 497dff7809901ac3319c01fb2f28ad807b708be5
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Feb 28 16:14:27 2017

[inspector] restore provisional breakpoints smarter

For breakpoints which are set by setBreakpointByUrl(url:..) backend calculates source hint on first related breakpoints resolved event and then uses this hint to adjust breakpoint position in later arrived scripts with the same url or on page reload.

Doc: https://docs.google.com/a/google.com/document/d/1VtWo_-jelzEXSNbjESGTtruZngzXgbHLexfTzxNlnjE/edit?usp=sharing

BUG= chromium:688776 
R=pfeldman@chromium.org, alph@chromium.org

Review-Url: https://codereview.chromium.org/2671193002
Cr-Commit-Position: refs/heads/master@{#43493}

[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/api.cc
[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/debug/debug-interface.h
[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/inspector/v8-debugger-agent-impl.h
[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/src/inspector/v8-debugger-script.h
[add] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/test/inspector/debugger/restore-breakpoint-expected.txt
[add] https://crrev.com/497dff7809901ac3319c01fb2f28ad807b708be5/test/inspector/debugger/restore-breakpoint.js

Owner: kozy@chromium.org

Comment 4 by kozy@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment