New issue
Advanced search Search tips

Issue 688766 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Keepalive count is reported as zero for all Extensions, even ones with one or more windows open

Project Member Reported by w...@chromium.org, Feb 5 2017

Issue description

Chrome Version: 58.0.3002.0 canary (64-bit)
OS: Windows 10

What steps will reproduce the problem?
(1) Launch Chrome.
(2) Install the Hangouts extension.
(3) Use the extension action icon to open the Hangouts window.
(4) Open Task Manager & enable the Keepalive count column.

What is the expected result?

Expect that the Keepalive count for Hangouts is at least 1, since there is a Hangouts window open, "using" the Extension.

What happens instead?

All Extensions are reported with a Keepalive count of zero.

Tentatively tagging as a Windows-specific bug, since the new Keepalive count column was developed and verified to work under Linux.
 

Comment 1 by w...@chromium.org, Feb 5 2017

Keepalive count appears to work correctly for Chrome Apps but not at all for Extensions. :(

Comment 2 by w...@chromium.org, Feb 13 2017

Status: Started (was: Assigned)
Looks like the problem is simply that zero keepalive-count was being reported for Extensions with persistent background pages, rather than N/A.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/714dde19e175737a2915afce6e303ff587818368

commit 714dde19e175737a2915afce6e303ff587818368
Author: wez <wez@chromium.org>
Date: Tue Feb 14 22:26:03 2017

Don't report a keepalive count for persistent pages.

Rather than reporting a keepalive count of zero for extensions with
persistent background pages, return -1, to indicate that the keepalive
count is meaningless for that extension.

BUG= 688766 

Review-Url: https://codereview.chromium.org/2689963003
Cr-Commit-Position: refs/heads/master@{#450495}

[modify] https://crrev.com/714dde19e175737a2915afce6e303ff587818368/chrome/browser/extensions/process_manager_browsertest.cc
[modify] https://crrev.com/714dde19e175737a2915afce6e303ff587818368/extensions/browser/process_manager.cc
[modify] https://crrev.com/714dde19e175737a2915afce6e303ff587818368/extensions/browser/process_manager.h

Comment 4 by w...@chromium.org, Feb 14 2017

Status: Fixed (was: Started)

Sign in to add a comment