New issue
Advanced search Search tips

Issue 688764 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

exceptions must be old-style classes or derived from BaseException, not NoneType

Reported by sl1pk...@gmail.com, Feb 5 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.8 Safari/537.36

Steps to reproduce the problem:
1. download 58.0.3000.4 sources from dev channel
2. configure the installation
3. try build

What is the expected behavior?
Build OK

What went wrong?
[107/29326] /usr/bin/python2 ../../chrome/browser/resources/vulcanize_gn.py --host downloads --html_in_file downloads.html --html_out_file vulcanized.html --js_out_file crisper.js --input_type FOLDER --input ../../chrome/browser/resources/md_downloads --insert_in_head \<base\ href=chrome://downloads\> --out_folder gen/chrome/browser/resources/md_downloads --depfile gen/chrome/browser/resources/md_downloads/vulcanize.d
FAILED: gen/chrome/browser/resources/md_downloads/vulcanized.html gen/chrome/browser/resources/md_downloads/crisper.js 
/usr/bin/python2 ../../chrome/browser/resources/vulcanize_gn.py --host downloads --html_in_file downloads.html --html_out_file vulcanized.html --js_out_file crisper.js --input_type FOLDER --input ../../chrome/browser/resources/md_downloads --insert_in_head \<base\ href=chrome://downloads\> --out_folder gen/chrome/browser/resources/md_downloads --depfile gen/chrome/browser/resources/md_downloads/vulcanize.d
../../third_party/node/linux/node-linux-x64/bin/node ../../third_party/node/node_modules/vulcanize/bin/vulcanize --exclude crisper.js --exclude chrome://resources/html/polymer.html --exclude web-animations-next-lite.min.js --exclude load_time_data.js --exclude strings.js --exclude text_defaults.css --exclude text_defaults_md.css --inline-css --inline-scripts --strip-comments --redirect "chrome://resources/cr_elements/|../../ui/webui/resources/cr_elements" --redirect "chrome://resources/css/|../../ui/webui/resources/css" --redirect "chrome://resources/html/|../../ui/webui/resources/html" --redirect "chrome://resources/js/|../../ui/webui/resources/js" --redirect "chrome://resources/polymer/v1_0/|../../third_party/polymer/v1_0/components-chromium" --out-request-list /tmp/makepkg/chromium-dev/src/chromium-58.0.3000.4/out/Release/gen/chrome/browser/resources/md_downloads/request_list.txt --redirect "/|/tmp/makepkg/chromium-dev/src/chromium-58.0.3000.4/chrome/browser/resources/md_downloads" --redirect "chrome://downloads/|/tmp/makepkg/chromium-dev/src/chromium-58.0.3000.4/chrome/browser/resources/md_downloads" /downloads.html failed: /bin/sh: ../../third_party/node/linux/node-linux-x64/bin/node: No such file or directory

Traceback (most recent call last):
  File "../../chrome/browser/resources/vulcanize_gn.py", line 220, in <module>
    main()
  File "../../chrome/browser/resources/vulcanize_gn.py", line 213, in main
    _vulcanize(vulcanize_input_folder, args)
  File "../../chrome/browser/resources/vulcanize_gn.py", line 153, in _vulcanize
    args.html_in_file)])
  File "../../chrome/browser/resources/vulcanize_gn.py", line 90, in _run_node
    raise
TypeError: exceptions must be old-style classes or derived from BaseException, not NoneType

Did this work before? N/A 

Chrome version: 57.0.2987.8  Channel: dev
OS Version: Archlinux
Flash Version: Shockwave Flash 24.0 r0

python2 2.7.13
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by sl1pk...@gmail.com, Feb 5 2017

change

# First download checksum file.
rm "SHASUMS256.txt"
wget "https://nodejs.org/dist/latest-v6.x/SHASUMS256.txt"

to

# First download checksum file.
rm -fr "SHASUMS256.txt"
wget "https://nodejs.org/dist/${NODE_VERSION}/SHASUMS256.txt"

in ./third_party/node/update_node_binaries

install npm package

and execute the scripts:

  ./third_party/node/update_node_binaries
  ./third_party/node/update_npm_deps


solve (still in test) the problem

remember. run the scripts after run remove_bundled_libraries.py script

greetings
Cc: dbeam@chromium.org dpa...@chromium.org
Components: UI>Browser>WebUI
Labels: Proj-MaterialDesign-WebUI
Have you ran gclient sync?

Comment 7 by dbeam@chromium.org, Feb 6 2017

sl1pkn07@: please run `gclient runhooks` or `gclient sync` and try again

Comment 8 by sl1pk...@gmail.com, Feb 6 2017

the problem is solved by steps in #c4

maybe the sources in dev channel (https://commondatastorage.googleapis.com/chromium-browser-official/chromium-58.0.3000.4.tar.xz) don't have the node binaries attached

but anyway, the changes is needed because:

first: can lead to fail if the file SHASUMS256.txt not exist in the first time in the third_party/node directory

second: https://nodejs.org/dist/latest-v6.x/SHASUMS256.txt (see the content of the txt file) download the checksums for version 6.9.5 instead of 6.9.4 hardcoded in the update_node_binaries script
https://chromium.googlesource.com/chromium/src.git/+/master/third_party/node/update_node_binaries#18

greetings

Comment 9 by dbeam@chromium.org, Feb 6 2017

Status: WontFix (was: Unconfirmed)
sl1pkn07@: chromium only supports some versions of node (the ones we bundle, not any SHA1 version of node you find)
and sorry, the main probem is 

failed: /bin/sh: ../../third_party/node/linux/node-linux-x64/bin/node: No such file or directory 

instead of

exceptions must be old-style classes or derived from BaseException, not NoneType

greetings

Comment 11 Deleted

this issue is fixed in 58.0.3004.3

now include nodejs sources in the tarball. 

and can symlink system nodejs into 

third_party/node/linux/node-linux-x64/bin/

with this, no need run ./third_party/node/update_node_binaries and ./third_party/node/update_npm_deps script


greetings

Sign in to add a comment