Issue 688622 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	xixuan@chromium.org
Closed:	Feb 2017
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	----
Hotlist-Fixit cros-infra-fixedit-q117 VerifyIn-59 VerifyIn-60 VerifyIn-61

Remove unused user RPCs

Project Member Reported by xixuan@chromium.org, Feb 4 2017

Issue description

The user-related RPC list:
add_user
delete_user
modify_user

From Richard: "Looking at the code, the only client of "modify_user" is the "UserPreferences"
tab, in frontend/client/src/autotest/afe/UserPreferencesView.java.  I think
we'd be better off deleting the UserPreferences support, and then all three
of these RPC calls."

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/672f40a930ed4d2c53f5584cf2ca47b77c2a100c

commit 672f40a930ed4d2c53f5584cf2ca47b77c2a100c
Author: xixuan <xixuan@chromium.org>
Date: Mon Feb 06 22:50:34 2017

autotest: Remove RPCs related to users & Remove UserPreferences page.

This CL:
1. Remove RPCs related to users, including add/delete/modify_user.
2. Remove UserPreferences page.

BUG= chromium:688622 
TEST=Run local AFE, kick off a verify job.
Run frontend_unittest & rpc_interface_unittest.

Change-Id: Ifa048635418240d6d9145e1ebf4ab2b601483bd4
Reviewed-on: https://chromium-review.googlesource.com/437728
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/672f40a930ed4d2c53f5584cf2ca47b77c2a100c/frontend/client/src/autotest/public/AfeClient.html
[modify] https://crrev.com/672f40a930ed4d2c53f5584cf2ca47b77c2a100c/frontend/client/src/autotest/afe/AfeClient.java
[delete] https://crrev.com/b7e94bbd5dbccb9c036b8e260d18c8d914bf2257/frontend/client/src/autotest/afe/UserPreferencesView.java
[modify] https://crrev.com/672f40a930ed4d2c53f5584cf2ca47b77c2a100c/frontend/afe/doctests/001_rpc_test.txt
[modify] https://crrev.com/672f40a930ed4d2c53f5584cf2ca47b77c2a100c/frontend/afe/rpc_interface.py