New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688614 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 691794



Sign in to add a comment

Merge FrameHost and Page

Project Member Reported by sashab@chromium.org, Feb 4 2017

Issue description

FrameHost and Page were split in preparation for another project, but this no longer makes sense. Merge methods from FrameHost into Page and replace usages so we are only left with the Page class.
 
Components: Blink>Internals

Comment 2 by sashab@chromium.org, Feb 20 2017

Blocking: 691794
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb902e3e380be95b54d49d49c702dc1a20b11cdf

commit fb902e3e380be95b54d49d49c702dc1a20b11cdf
Author: sashab <sashab@chromium.org>
Date: Mon Mar 20 07:31:36 2017

Change Frame to store a Page instead of a FrameHost.

Since all methods have already been removed off FrameHost, change Frame
to store a Page and remove the indirection caused from going through the
FrameHost. This is pre-work to remove FrameHost. LocalFrame and
RemoteFrame will be updated similarly in a follow-up patch.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2756383002
Cr-Commit-Position: refs/heads/master@{#458022}

[modify] https://crrev.com/fb902e3e380be95b54d49d49c702dc1a20b11cdf/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/fb902e3e380be95b54d49d49c702dc1a20b11cdf/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/fb902e3e380be95b54d49d49c702dc1a20b11cdf/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/fb902e3e380be95b54d49d49c702dc1a20b11cdf/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662

commit 2489d6c5bdbfb5d1ac15afcb30870c30c3b47662
Author: sashab <sashab@chromium.org>
Date: Tue Mar 21 03:59:01 2017

Change LocalFrame to take a Page instead of a FrameHost

Now that Frame stores a Page, this just updates the LocalFrame
constructor to take a Page. This is pre-work to remove FrameHost.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2763513002
Cr-Commit-Position: refs/heads/master@{#458306}

[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba66233b874fd4f9faac1feed4dbe1a83e6458ed

commit ba66233b874fd4f9faac1feed4dbe1a83e6458ed
Author: sashab <sashab@chromium.org>
Date: Wed Mar 22 07:21:15 2017

Removed use of FrameHost in FrameView.cpp

This is pre-work to remove FrameHost.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2765123002
Cr-Commit-Position: refs/heads/master@{#458662}

[modify] https://crrev.com/ba66233b874fd4f9faac1feed4dbe1a83e6458ed/third_party/WebKit/Source/core/frame/FrameView.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37

commit 24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37
Author: sashab <sashab@chromium.org>
Date: Wed Mar 22 07:34:13 2017

Remove a bunch of unused frameHost() methods

Remove a bunch of unused frameHost() getter methods, including one on
Document which required removing existing callsites. This is pre-work to
remove FrameHost.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2763123003
Cr-Commit-Position: refs/heads/master@{#458668}

[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/input/GestureManager.h
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b6e31dfcf2062a3dec7942daf86dc79864c14e8

commit 2b6e31dfcf2062a3dec7942daf86dc79864c14e8
Author: sashab <sashab@chromium.org>
Date: Tue Mar 28 02:10:51 2017

Made Frame constructors (and subclasses) take Page& instead of Page*

Made Frame constructors (and subclasses LocalFrame and RemoteFrame) take
Page& instead of Page*, since this parameter can't be null.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2762423003
Cr-Commit-Position: refs/heads/master@{#459985}

[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/frame/RemoteFrame.h
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/2b6e31dfcf2062a3dec7942daf86dc79864c14e8/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6badfa25e06f54413e408cd6d14427a7f44356a1

commit 6badfa25e06f54413e408cd6d14427a7f44356a1
Author: sashab <sashab@chromium.org>
Date: Tue Mar 28 04:58:22 2017

Remove Frame::host() method

Remove Frame::host() method and replace boolean checks (the only
remaining calls) with Frame::page() which is an equivalent check.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2769263004
Cr-Commit-Position: refs/heads/master@{#460016}

[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/DOMWindow.h
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/6badfa25e06f54413e408cd6d14427a7f44356a1/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015f5eb0b4fb4d6b3de8cb8aeda89fb1eacc2e24

commit 015f5eb0b4fb4d6b3de8cb8aeda89fb1eacc2e24
Author: sashab <sashab@chromium.org>
Date: Wed Mar 29 04:22:26 2017

Remove Page::m_frameHost

Remove Page::m_frameHost and FrameHost() method.

BUG= 688614 

Review-Url: https://codereview.chromium.org/2771983002
Cr-Commit-Position: refs/heads/master@{#460275}

[modify] https://crrev.com/015f5eb0b4fb4d6b3de8cb8aeda89fb1eacc2e24/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/015f5eb0b4fb4d6b3de8cb8aeda89fb1eacc2e24/third_party/WebKit/Source/core/page/Page.h

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94acef8a7271308a8cda44c1c21f91791cb6aea3

commit 94acef8a7271308a8cda44c1c21f91791cb6aea3
Author: sashab <sashab@chromium.org>
Date: Wed Mar 29 07:24:11 2017

Remove FrameHost class

BUG= 688614 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2774823002
Cr-Commit-Position: refs/heads/master@{#460316}

[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/BUILD.gn
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/BrowserControls.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/FrameConsole.h
[delete] https://crrev.com/6df9dbce1fc7b4b91054df57a21fe0a4b60acc2c/third_party/WebKit/Source/core/frame/FrameHost.cpp
[delete] https://crrev.com/6df9dbce1fc7b4b91054df57a21fe0a4b60acc2c/third_party/WebKit/Source/core/frame/FrameHost.h
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/probe/CoreProbes.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/ResizeViewportAnchor.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/94acef8a7271308a8cda44c1c21f91791cb6aea3/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment