Support Presentation from Chrome Custom Tab |
||||||||||
Issue descriptionWhen presenting from a CCT (such as within Gmail), Chrome is opened and starts presenting the most recent tab instead of presenting the WebVR content. Reproduction steps: 1. Download Chrome Canary from the Play Store 2. Download and install the CCTClient.apk from https://drive.google.com/corp/drive/u/0/folders/0B4IaoiF9wc9qfmM1eXZhOHlubkR6elp3czc2aExZd25SMzg0UnVfMDF4UTM3QVZzMmVIRG8 3. Open up "Chrome Custom Tabs Example" app 4. Enter "https://webvr.info/samples/03-vr-presentation.html" for the URL and select com.chrome.canary for the package. 5. Select "Connect to the service" and "Launch URL in a Chrome Custom Tab" 6. Select the "Enter VR" button Expected result: The WebVR content is presented in CCT just as if it were a normal Chrome instance. Actual result: Chrome is opened and whatever tab was open most recently is rendered with the stereoscopic view.
,
Feb 7 2017
Marking this issue as work to support presentation from CCT. I'll file a separate bug to block presentation in CCT (per Comment #1).
,
Feb 7 2017
,
Feb 8 2017
Issue 689756 has been merged into this issue.
,
Feb 8 2017
Blocking on issue 683302 since that is currently tracking changes related to item #2. Even if the fix isn't strictly necessary, we'd need to share the version check.
,
Feb 9 2017
Issue 689775 has been merged into this issue.
,
Mar 2 2017
,
Mar 6 2017
,
Mar 13 2017
Issue 701040 has been merged into this issue.
,
Mar 13 2017
Since this also affects apps launched with "Add to Home screen" links ( issue 701040 ), I think the priority is higher.
,
Mar 24 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99465cbe0eed1bd1a5ed3e2267581248a76d3138 commit 99465cbe0eed1bd1a5ed3e2267581248a76d3138 Author: mthiesse <mthiesse@chromium.org> Date: Thu Apr 13 22:24:09 2017 Enable WebVR presentation from Chrome Custom Tab Since CCT can't be resumed from an Activity PendingIntent, we use a Broadcast PendingIntent to resume the activity that triggered the DON flow. The REORDER_TASKS permission is required to bring our activity back to the foreground inside the VR Entry result BroadcastReceiver. BUG= 688611 Review-Url: https://codereview.chromium.org/2776243007 Cr-Commit-Position: refs/heads/master@{#464571} [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java [modify] https://crrev.com/99465cbe0eed1bd1a5ed3e2267581248a76d3138/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
Apr 18 2017
,
Apr 18 2017
,
Jul 4
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mthiesse@chromium.org
, Feb 6 2017