See also https://github.com/KhronosGroup/WebGL/issues/2284 describing the conformance tests which are missing for these APIs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd3c00a7c7b91c60409cf5d4032c8269c7320c41

commit bd3c00a7c7b91c60409cf5d4032c8269c7320c41
Author: zmo <zmo@chromium.org>
Date: Wed Feb 15 01:29:42 2017

Implement WebGL2's uniform*() with sub source.

BUG= 688598 
TEST=conformance2/uniforms/*
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692853006
Cr-Commit-Position: refs/heads/master@{#450544}

[modify] https://crrev.com/bd3c00a7c7b91c60409cf5d4032c8269c7320c41/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/bd3c00a7c7b91c60409cf5d4032c8269c7320c41/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/bd3c00a7c7b91c60409cf5d4032c8269c7320c41/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/bd3c00a7c7b91c60409cf5d4032c8269c7320c41/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/bd3c00a7c7b91c60409cf5d4032c8269c7320c41/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

PMs: we would really like to merge this back to M57. It is a gap in the public API between Chrome and Firefox, and a key user (the Emscripten maintainers) have run into it. If we could get this fix out six weeks earlier, it would ease a lot of developer pain. It is very low risk, is a mechanical fix, and has been thoroughly tested. May we please merge back to M57?

I'd like to point out that a major customer, Unity, first ran into this problem with the WebGL 2.0 upgrade in Emscripten. It's not a theoretical problem.

Change listed at #2 didn't make to last night Canary. Before approving merge to M57, Can we please wait until this change is well baked/verified in Canary and safe to merge ? Also do we have enough automation/test coverage for this change?

Note: If merge happens by Friday (03/17), then we can pick it up for next week M57 Beta release.

Yes, this is covered by a WebGL2 conformance test, which is pretty thorough.

I'll roll it into our bots so the coverage will be automatic (right now I tested manually)

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a7c59afb439110a3f91f9ad8be724b6e81f9bce

commit 3a7c59afb439110a3f91f9ad8be724b6e81f9bce
Author: Zhenyao Mo <zmo@chromium.org>
Date: Thu Feb 16 01:39:25 2017

Implement WebGL2's uniform*() with sub source.

BUG= 688598 
TEST=conformance2/uniforms/*
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2692853006
Cr-Commit-Position: refs/heads/master@{#450544}
(cherry picked from commit bd3c00a7c7b91c60409cf5d4032c8269c7320c41)

Review-Url: https://codereview.chromium.org/2698863002 .
Cr-Commit-Position: refs/branch-heads/2987@{#538}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/3a7c59afb439110a3f91f9ad8be724b6e81f9bce/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/3a7c59afb439110a3f91f9ad8be724b6e81f9bce/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/3a7c59afb439110a3f91f9ad8be724b6e81f9bce/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/3a7c59afb439110a3f91f9ad8be724b6e81f9bce/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/3a7c59afb439110a3f91f9ad8be724b6e81f9bce/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h