New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688597 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Last_n: snapshot should still be saved if page finishes loading while hidden

Project Member Reported by carlosk@chromium.org, Feb 4 2017

Issue description

The initial implementation of user interaction triggers simply ignores the WasHidden event if the page is not loaded enough. However that loading can still continue in the background potentially attaining a useful enough stage for a snapshot.

We could/should improve it so that if this situation happens the page is still saved so to not waste this opportunity where we have all data we need available.
 

Comment 1 by chili@chromium.org, Feb 7 2017

Labels: Hotlist-Fixit

Comment 2 by chili@chromium.org, Feb 7 2017

Cc: dim...@chromium.org
Fixit update: this should be OK for a fixit and no extra investigation is needed.
The main places affected in the codebase will be:
RecentTabHelper::WasHidden
and
RecentTabHelper::DidFinishNavigation

And the change itself could be based off the scheduling-for-when-the-page-is-loaded done for downloads in:
RecentTabHelper::ObserveAndDownloadCurrentPage

Sign in to add a comment