New issue
Advanced search Search tips

Issue 688596 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Feb 2017
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Viewport's non-fixed-attachment gradient background should be invalidated when document element size changes

Project Member Reported by wangxianzhu@chromium.org, Feb 3 2017 
Viewport's non-fixed-attachment gradient background is painted according to the size of the document element. It should be invalidated when document element size changes.

Comment 1 by wangxianzhu@chromium.org, Feb 3 2017 

Test case.
gradient.html
346 bytes View Download

Comment 2 by wangxianzhu@chromium.org, Feb 16 2017

Summary: Non-fixed-attachment gradient background should be invalidated when document element size changes (was: Gradient background should be invalidated when body size changes)

Comment 3 by wangxianzhu@chromium.org, Feb 16 2017

Description: Show this description

Comment 4 by wangxianzhu@chromium.org, Feb 16 2017

Summary: Viewport's non-fixed-attachment gradient background should be invalidated when document element size changes (was: Non-fixed-attachment gradient background should be invalidated when document element size changes)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d34bb14bf30e4885f704336b0658cd32ba01e108

commit d34bb14bf30e4885f704336b0658cd32ba01e108
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Feb 17 07:48:11 2017

Fix viewport background invalidation when HTML size changes

Non-fixed-attachment viewport background uses root element as the
background positioning area. If HTML size changes, and the background
needs paint invalidation on the resize, we should invalidate the
LayoutView.

BUG= 688596 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2699463004
Cr-Commit-Position: refs/heads/master@{#451265}

[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[add] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/viewport-gradient-background-html-resize-expected.html
[add] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/viewport-gradient-background-html-resize-expected.txt
[add] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/viewport-gradient-background-html-resize.html
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-frameset-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-html-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/line-flow-with-floats-2-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/line-flow-with-floats-8-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/table-shrink-row-repaint-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/text-match-document-change-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/window-resize-percent-html-expected.txt
[delete] https://crrev.com/ddd53c2ef164f4e22c55d3d69b9c1fb386119375/third_party/WebKit/LayoutTests/virtual/spv2/fast/repaint/border-radius-repaint-2-expected.txt
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/BUILD.gn
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
[add] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/ViewPaintInvalidator.cpp
[add] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/core/paint/ViewPaintInvalidator.h
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.cpp
[modify] https://crrev.com/d34bb14bf30e4885f704336b0658cd32ba01e108/third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.h

Comment 6 by wangxianzhu@chromium.org, Feb 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment