New issue
Advanced search Search tips

Issue 688593 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Version/Checksum mismatch in shader cache should trigger deletion

Project Member Reported by ericrk@chromium.org, Feb 3 2017

Issue description

When we detect that shader from our on-disk cache is invalid, we correctly skip loading it. However, we leave the shader in the cache, meaning that on each subsequent restart of Chrome we will try and fail to load it.

This both wastes resources, as well as making it hard to assess the true number of shaders which are failing our checks (as UMAs keep re-counting the same bad shaders on each load).

We should update the on-disk cache to evict a shader if it fails to load. We might also consider evicting the entire cache if any shader fails to load, as the most common case of this is a version change, which will invalidate all shaders.

 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by piman@chromium.org, Feb 12 2018

Status: Available (was: Untriaged)

Sign in to add a comment