New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688583 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

snapped windows may overlap or leave space when display workarea changes

Project Member Reported by warx@chromium.org, Feb 3 2017

Issue description

Currently I saw this two issues:
(1) layout shelf to left,
(2) snap one window to left, snap one window to right
(3) layout shelf to bottom,

We could see a space between two windows.
 
Screenshot from 2017-02-03 15:29:35.png
170 KB View Download
Screenshot from 2017-02-03 15:30:03.png
204 KB View Download

Comment 1 by warx@chromium.org, Feb 3 2017

Cc: abodenha@chromium.org osh...@chromium.org kuscher@chromium.org
again, (1) layout shelf to bottom, (2) snap one window to left, one window to right, (3) layout shelf to left

We could see overlap between two windows.

Shall we make an improvement here?
Screenshot from 2017-02-03 15:30:32.png
171 KB View Download
Screenshot from 2017-02-03 15:30:50.png
164 KB View Download

Comment 2 by warx@chromium.org, Feb 16 2017

Summary: Splitview windows may overlap or leave space when display workarea changes (was: Improve snapped windows management)

Comment 3 by osh...@chromium.org, Feb 17 2017

Cc: omrilio@chromium.org
This is because ChromeOS does not have SplitView yet :)

We have a plan (without details :) to implement real SplitView for Tablet,
although just keeping the half size may be useful.

Comment 4 by warx@chromium.org, Nov 20 2017

Summary: snapped windows may overlap or leave space when display workarea changes (was: Splitview windows may overlap or leave space when display workarea changes)

Comment 5 by vadimt@chromium.org, Nov 29 2017

Labels: Not-Touch-Friendly-Launcher
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e2da8acdd54eeb8a4485133561c67f1aba5f65

commit 81e2da8acdd54eeb8a4485133561c67f1aba5f65
Author: Qiang Xu <warx@chromium.org>
Date: Fri Dec 08 20:54:01 2017

cros: keep snapped window width ratio against display workarea width

changes:
- Keep snapped window width ratio against display workarea width. The
  ratio is updated on (1) snapped state entered (2) bounds event upon
  snapped state. The ratio is applied on adjusting snapped bounds.
- WindowStateTest.UpdateSnapWidthRatioTest to test above change.
- Add test coverage for  crbug.com/688583 .
- added test coverage for moving (maximized/fullscreen/snapped) window
  to another display.

Bug:  783589 ,  778438 ,  688583 
Test: emulator test and added test coverage
Change-Id: Ibbc3afea87342e75c591c23ecd3a4fded5254cff
Reviewed-on: https://chromium-review.googlesource.com/764114
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522869}
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/display/display_move_window_util_unittest.cc
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/default_state.cc
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state.cc
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state.h
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 7 by warx@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)
Status: Archived (was: Fixed)

Sign in to add a comment