StartupBrowserCreatorImpl refactor tech debt |
|||||
Issue descriptionThis bug tracks cleanup efforts left after the SBCI refactor.
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4000f08774959883da8bef366561798e98cb50eb commit 4000f08774959883da8bef366561798e98cb50eb Author: tmartino <tmartino@chromium.org> Date: Tue May 09 04:42:28 2017 [Desktop FRE] Fix incorrect emission of histogram This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram is emitted for the wrong page--it is meant to track chrome://welcome-win10, which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old default browser promo. This CL also addresses a refactoring nit requested in a prior review. BUG= 688574 Review-Url: https://codereview.chromium.org/2848713002 Cr-Commit-Position: refs/heads/master@{#470218} [modify] https://crrev.com/4000f08774959883da8bef366561798e98cb50eb/chrome/browser/ui/startup/startup_tab_provider.cc
,
May 9 2017
,
May 10 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 12 2017
Please merge your change to M59 branch 3071 by 4:00 PM PT, Monday (05/15) so we can take it in for next week beta release. Thank you.
,
May 15 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/248a38b867f44add9113570c34c6eef71090da80 commit 248a38b867f44add9113570c34c6eef71090da80 Author: Francois Doray <fdoray@chromium.org> Date: Mon May 15 18:56:06 2017 [Desktop FRE] Fix incorrect emission of histogram This CL fixes a bug where the Welcome.Win10.NewPromoPageAdded histogram is emitted for the wrong page--it is meant to track chrome://welcome-win10, which corresponds to Welcome.Win10.OldPromoPageAdded tracking the old default browser promo. This CL also addresses a refactoring nit requested in a prior review. BUG= 688574 Review-Url: https://codereview.chromium.org/2848713002 Cr-Original-Commit-Position: refs/heads/master@{#470218} Review-Url: https://codereview.chromium.org/2879193004 . Cr-Commit-Position: refs/branch-heads/3071@{#562} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/248a38b867f44add9113570c34c6eef71090da80/chrome/browser/ui/startup/startup_tab_provider.cc
,
Jun 15 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 9 2017