Issue 688566 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	█ xiaoyinh@chromium.org Last visit > 30 days ago
Closed:	Apr 2017
Cc:	snanda@chromium.org r...@chromium.org █ mcchou@chromium.org █ scheib@chromium.org █ ortuno@chromium.org █ hennessywill@chromium.org
Components:	IO>Bluetooth OS>Systems>Bluetooth
EstimatedDays:	----
NextAction:	----
OS:	Linux , Chrome
Pri:	1
Type:	Bug
M-59

Add a test for testing Bluetooth service data/manufacturer data.

Project Member Reported by st...@chromium.org, Feb 3 2017

Issue description

Currently service data sent on Bluetooth is tested only for MacOS via the BluetoothTest.GetServiceDataUUIDs_GetServiceDataForUUID test. This leaves out coverage for BlueZ platforms. Recently a bug was found in this code.

We need to add code to make sure service data and manufacturer data are being returned correctly.

For this, we need to modify the Bluetooth D-Bus stubs to create devices with service and manufacturer data. This then needs to be tested via the platform independent test fixture - service data via the test mentioned above, and manufacturer data via a new test.

Assigning to Sarah since she will be working on Bluetooth code in Chrome, this seems like an ideal starter bug for her.

Comment 1 by r...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5

commit ab0e2203cdb233620ef341cc297fc3d87ca0ddc5
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Mon Apr 03 22:48:25 2017

Bluetooth: Add service data unit tests for chromeos

This CL verifies that:
1. service data is populated correctly during device creation.
2. service data is updated correctly on property changed.

BUG= 688566 

Review-Url: https://codereview.chromium.org/2783733002
Cr-Commit-Position: refs/heads/master@{#461565}

[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/dbus/fake_bluetooth_device_client.h
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/test/bluetooth_test_bluez.cc
[modify] https://crrev.com/ab0e2203cdb233620ef341cc297fc3d87ca0ddc5/device/bluetooth/test/bluetooth_test_mac.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d296cacc709ef513b7b1dde1a1ce272f7ff261d0

commit d296cacc709ef513b7b1dde1a1ce272f7ff261d0
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Tue Apr 04 16:52:20 2017

Reland: Bluetooth: Add service data unit tests for chromeos

This CL verifies that:
1. service data is populated correctly during device creation.
2. service data is updated correctly on property changed.

BUG= 688566 

Review-Url: https://codereview.chromium.org/2797613002
Cr-Commit-Position: refs/heads/master@{#461751}

[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/dbus/fake_bluetooth_device_client.h
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/test/bluetooth_test.h
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/test/bluetooth_test_bluez.cc
[modify] https://crrev.com/d296cacc709ef513b7b1dde1a1ce272f7ff261d0/device/bluetooth/test/bluetooth_test_mac.mm

Comment 4 by xiaoyinh@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)

Comment 5 by rjahagir@chromium.org, Apr 27 2017

Status: Verified (was: Fixed)

►

Issue 688566 link

Issue metadata

Add a test for testing Bluetooth service data/manufacturer data.

Issue description

Comment 1 by r...@chromium.org, Mar 3 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 3 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 4 2017

Comment 3 Deleted

Comment 4 by xiaoyinh@chromium.org, Apr 7 2017

Comment 4 Deleted

Comment 5 by rjahagir@chromium.org, Apr 27 2017

Comment 5 Deleted

Sign in to add a comment