New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688561 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[text autosizing] ruby elements are not autosized

Project Member Reported by skobes@chromium.org, Feb 3 2017

Issue description

Test case: https://output.jsbin.com/jugela/quiet

All text is autosized except for the <ruby> element, which looks unpleasant.
 
testcase.html
1012 bytes View Download
screenshot.png
140 KB View Download
Cc: joh...@chromium.org mukai@chromium.org
 Issue 115444  has been merged into this issue.
Labels: -Pri-3 Pri-2
Acording to <ruby>'s layout tree:
layoutRuby(block/inline)
    layoutRubyRun(inline-block)
        layoutRubyBase(block)
            layoutInline(<rb>)
                text
        layoutRubyText(block, <rt>)
            text

LayoutRubyRun is inline-block, and we will create a cluster for it. So autosize will be broken by this cluster.

Maybe we could use the similar design as inflateAutoTable:
when autosizing <ruby>:
  1. skip inline-block objects(rubyrun)
  2. use "DescendToInnerBlocks" behavior to autosize inner content

Thank you for working on this. :)

The approach in #3 sounds ok to me.

Comment 7 by skobes@chromium.org, Feb 21 2017

Status: Fixed (was: Available)

Comment 8 by skobes@chromium.org, Mar 22 2017

Cc: skobes@chromium.org
 Issue 400828  has been merged into this issue.

Sign in to add a comment