Bad error message running gclient runhooks |
|||||
Issue descriptionError message should be "download_from_google_storage is not in your PATH, please add it or install depot_tools and then add its directory to your PATH" Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-289944-2.tgz .......... Done. Creating directory /usr/local/google/home/chrishtr/git/chromium/src/third_party/llvm-build/Release+Asserts clang 289944-2 unpacked ________ running '/usr/bin/python src/build/util/lastchange.py -o src/build/util/LASTCHANGE' in '/usr/local/google/home/chrishtr/git/chromium' ________ running '/usr/bin/python src/build/util/lastchange.py --git-hash-only -s src/third_party/WebKit -o src/build/util/LASTCHANGE.blink' in '/usr/local/google/home/chrishtr/git/chromium' ________ running '/usr/bin/python src/build/util/lastchange.py -m SKIA_COMMIT_HASH -s src/third_party/skia --header src/skia/ext/skia_commit_hash.h' in '/usr/local/google/home/chrishtr/git/chromium' ________ running 'download_from_google_storage --no_resume --platform=win32 --no_auth --bucket chromium-gn -s src/buildtools/win/gn.exe.sha1' in '/usr/local/google/home/chrishtr/git/chromium' Traceback (most recent call last): File "/usr/local/google/home/chrishtr/depot_tools/gclient.py", line 2128, in <module> sys.exit(main(sys.argv[1:])) File "/usr/local/google/home/chrishtr/depot_tools/gclient.py", line 2114, in main return dispatcher.execute(OptionParser(), argv) File "/usr/local/google/home/chrishtr/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/usr/local/google/home/chrishtr/depot_tools/gclient.py", line 1957, in CMDrunhooks return client.RunOnDeps('runhooks', args) File "/usr/local/google/home/chrishtr/depot_tools/gclient.py", line 1371, in RunOnDeps self.RunHooksRecursively(self._options) File "/usr/local/google/home/chrishtr/depot_tools/gclient.py", line 921, in RunHooksRecursively hook, cwd=self.root.root_dir, always=True) File "/usr/local/google/home/chrishtr/depot_tools/gclient_utils.py", line 303, in CheckCallAndFilterAndHeader return CheckCallAndFilter(args, **kwargs) File "/usr/local/google/home/chrishtr/depot_tools/gclient_utils.py", line 498, in CheckCallAndFilter **kwargs) File "/usr/local/google/home/chrishtr/depot_tools/subprocess2.py", line 262, in __init__ % (str(e), kwargs.get('cwd'), args[0])) OSError: Execution failed with error: [Errno 2] No such file or directory.
,
May 16 2017
Moving to Infra to get this bug triaged. I'm pretty sure it is still a problem.
,
May 17 2017
How are you running gclient (which is in depot_tools) without having depot_tools (and therefore download_from_google_storage) on PATH?
,
May 17 2017
I don't remember. Maybe I ran it with an explicit directory prefix? Regardless, it would be good to improve the error message (but not really a huge deal).
,
May 17 2017
There's not a reasonable way to improve the error message to reference depot_tools -- the message (or lack thereof, really) is coming directly from gclient. All gclient is trying to do is execute the things specified in hooks in the DEPS file. It's not gclient's fault if the DEPS file hasn't made sure that the executable it wants isn't available. We could improve the error message to say "unable to find executable", but that might be unreliable (OSError can be thrown for a lot of reasons). I'm willing to leave this Available, but I'm not going to work on it at the moment since I don't see a clear path to improvement, it's not a situation folks should run into during correct usage, and PolyGerrit is my priority right now :(
,
May 18 2017
Telling you what it was trying to run would be a reasonable first step.
,
May 18 2017
Actually, I guess it is telling you what is running above the traceback.
,
May 18 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tansell@chromium.org
, May 16 2017