New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688540 link

Starred by 1 user
Status: Fixed
Owner:
mef@chromium.org
Closed: Mar 2017
Cc:
█ kapishnikov@chromium.org
█ lilyhoughton@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Cronet] Cookie without creation date log spam on iOS.

Project Member Reported by mef@chromium.org, Feb 3 2017 
Some cookies imported from system cookie store have 0 creation time and cause error messages "Cookie without creation date" spamming debug log.

This issue is regression found during transition from CrNet to Cronet, because this message was disabled in CrNet.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0581caf436bae2e357a956598b2686092774683

commit d0581caf436bae2e357a956598b2686092774683
Author: mef <mef@chromium.org>
Date: Wed Feb 08 13:55:37 2017

[Cronet] Don't spam log if system cookie doesn't have creation time.

BUG= 688540 
TEST=components/cronet/tools/cr_cronet.py build-test | grep "Cookie"
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2671713006
Cr-Commit-Position: refs/heads/master@{#448982}

[modify] https://crrev.com/d0581caf436bae2e357a956598b2686092774683/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/d0581caf436bae2e357a956598b2686092774683/ios/BUILD.gn
[add] https://crrev.com/d0581caf436bae2e357a956598b2686092774683/ios/features.gni
[modify] https://crrev.com/d0581caf436bae2e357a956598b2686092774683/ios/net/BUILD.gn
[modify] https://crrev.com/d0581caf436bae2e357a956598b2686092774683/ios/net/cookies/cookie_store_ios.mm

Comment 2 by mef@chromium.org, Mar 17 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600742eb2a0a265ac9d441c02e92203c64e17d80

commit 600742eb2a0a265ac9d441c02e92203c64e17d80
Author: Misha Efimov <mef@chromium.org>
Date: Wed Aug 01 11:36:48 2018

[Cronet] Disable DCHECK(created) in GetCreationTimeFromObject.

- iOS 12 returns nil for system cookie with null creation time.

Bug:  865803 ,  688540 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I612b4ab55aedb0a2c0d9b2a7cb24418c5a0a6c19
Reviewed-on: https://chromium-review.googlesource.com/1157229
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579763}
[modify] https://crrev.com/600742eb2a0a265ac9d441c02e92203c64e17d80/ios/net/cookies/cookie_creation_time_manager.mm
►

Sign in to add a comment