New issue
Advanced search Search tips

Issue 688537 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools RDP: add parameters to DOMDebugger.getEventListeners

Project Member Reported by pfeldman@chromium.org, Feb 3 2017

Issue description

New parameters:

{ "name": "depth", "type": "integer", "optional": true, "description": "The maximum depth at which children should be retrieved, defaults to 1. Use -1 for the entire subtree or provide an integer larger than 0.", "experimental": true },

{ "name": "pierce", "type": "boolean", "optional": true, "description": "Whether or not iframes and shadow roots should be traversed when returning the subtree (default is false).", "experimental": true }

{ "name": "eventTypes", "type": "array", “items”: { “type”: “string” }, "optional": true, "description": "Only return event listeners of given types when present.", "experimental": true }
     
{ "name": "passive", "type": "boolean", "optional": true, "description": "Only return event listeners of given passive kind when specified.", "experimental": true }

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c65ab57b963b4f448f4b123ab1caee7b8509ee

commit d9c65ab57b963b4f448f4b123ab1caee7b8509ee
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Feb 10 02:38:15 2017

DevTools RDP: add parameters to DOMDebugger.getEventListeners

BUG= 688537 

Review-Url: https://codereview.chromium.org/2687003002
Cr-Commit-Position: refs/heads/master@{#449530}

[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners-expected.txt
[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners.html
[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/resources/iframe-with-listener.html
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c65ab57b963b4f448f4b123ab1caee7b8509ee

commit d9c65ab57b963b4f448f4b123ab1caee7b8509ee
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Feb 10 02:38:15 2017

DevTools RDP: add parameters to DOMDebugger.getEventListeners

BUG= 688537 

Review-Url: https://codereview.chromium.org/2687003002
Cr-Commit-Position: refs/heads/master@{#449530}

[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners-expected.txt
[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getEventListeners.html
[add] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/LayoutTests/inspector-protocol/dom/resources/iframe-with-listener.html
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/d9c65ab57b963b4f448f4b123ab1caee7b8509ee/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Cc: dtapu...@chromium.org
This returns the descendant event listeners correct? Is this going to be surfaced in the UI? (or has it already?)
Status: Fixed (was: Assigned)

Sign in to add a comment