Attaching system logs from my feedback report too.

Deleted: system_logs.txt 2.2 MB

system_logs.txt 2.2 MB View Download

Albert, looks like we are showing the update available icon even when no update is available. What do you think?

Here's another feedback report from today's canary  9260.0.0 : https://feedback.corp.google.com/#/Report/52866565764

I see this on M57 beta channel as well.

This Chromebook was running M53 and websites started nagging me that Chrome was out of date.  So I rebooted to take the update it had downloaded a few months ago, which got me to M54.  Then I visited chrome://settings and clicked update, waited for the download to finish, then rebooted into M57.  M57 prompted me to update even though no update was shown in chrome://settings.

Deleted: restart-to-update-no-update.png 203 KB

	restart-to-update-no-update.png 203 KB View Download

This happened to me when I updated my Asus Chromebox to 57 beta, and my Asus Cave when I updated to 57 beta

Sure it isn't Flash getting updated? 

If I go to chrome://components/ and check the (and receive) Flash component updater, I'll immediately see the yellow update arrow.

I'd really prefer not to have to reboot to take a Flash plugin update.  What if the user is multitasking with Android apps, ssh sessions, etc.?

adlr@, deymo@, or ketakid@ any thoughts here? The UI is just reporting the state given to us by update engine.

Could this be getting incorrectly triggered by a flash update as mentioned in comment #7?

Likely a flash update. Bouncing to Kerrnel

Yes this is likely a flash update. Ilja can confirm. Those bits just went to Beta last week. To Cernekee@ s point we are working on the problem of having to reboot after a flash update. However Flash updates are generally security issues that need patching right away without introducing a new UI paradigm -> hence the parity with the update mechanism for Chrome OS.

It surely sounds like the Flash component updater in #5. Also the log file in #1 seems to have a component installed.

This new UI isn't incorrect. Greg is out but AFAIK he is working on not getting the component to load without reboot. And it isn't true that in the past one didn't have to reboot to get a Flash update (it was just wrapped in an OS update with all the related overhead). Now with the component updater users get the Flash bits only, nor risk to the OS, and all that a few days to a week earlier than was possible before.

> This new UI isn't incorrect.

It can be confusing to see "This system is up to date" in Settings but "Restart to update" in the system menu.

But if the plan is to have Flash reload itself without rebooting, maybe the UI inconsistency is only a short term worry, as it will go away soon.

> The UI is just reporting the state given to us by update engine.

If I am interpreting the code correctly, |severity| comes from update_engine but |flash_update_available_| comes from component_updater in Chrome:

https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/system_tray_client.cc?type=cs&l=361

It might be nice in this situation to change "This system is up to date" to "Restart to update Flash". But yes, this hopefully won't last long.

Issue 691315 has been merged into this issue.

To ihf@'s point in comment 14 we did investigate having 2 separate strings to bring out the semantics for each but decided on opting for more simplicity instead by adopting the same string for both scenarios.

 Issue 686222  has been merged into this issue.

@ketakid was the decision to show the normal update UI approved by UI Review?

No, as there was no intention to change the UI. There is an update of the OS available (namely Flash) and we don't inform the user which particular bits are going to change. The bug here is not showing the string that an update is available, which confuses more users than I would have expected.

Here is the deck for the UI comps that was used for this UI review. https://docs.google.com/presentation/d/12UGY2se_BrLS_IELVfZywTQ-tz9O4Zk2M8iDnsBFzTU/edit 

 Issue 695575  has been merged into this issue.

Support team is concerned that these changes in 57 will cause customer confusion as they'll see more frequent notifications to update but it's non-obvious what is being updated.

- When do we plan to allow component update w/o reboot?
- Can we update UI to mention that *Flash* is being updated? I suspect notifying customer of what is being updated will reduce admin concerns over this change.

Is a reboot even needed? I hit Chrome://restart and the yellow update icon disappeared. 

A reboot is required to load and apply the new Flash player. I am surprised the yellow icon disappears if Chrome is restarted, I will have to investigate that separately. I filed  crbug.com/695603  for that.

Thank you for all the feedback folks. I have initiated a dialog with the UI team to revisit the UI paradigm we are using for this feature. We will update this thread with what we finalize.

Note, some of the confusion may be caused by  crbug.com/695654 , in which Chrome is downloading older versions of Flash and asking users to reboot. This bug will track the UI updates.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d0c679aff7cac0b26ca5c3652745db3393a817b

commit 2d0c679aff7cac0b26ca5c3652745db3393a817b
Author: ihf <ihf@chromium.org>
Date: Tue Feb 28 07:37:17 2017

Chrome OS component updater: UpdateSeverity::LOW

Use UpdateSeverity::LOW icon for Flash updates.

TEST=test_that <ip> desktopui_FlashSanityCheck.download-omaha-component
     See black arrow in grey instead of yellow circle.
BUG= 688532 

Review-Url: https://codereview.chromium.org/2720613007
Cr-Commit-Position: refs/heads/master@{#453540}

[modify] https://crrev.com/2d0c679aff7cac0b26ca5c3652745db3393a817b/chrome/browser/ui/ash/system_tray_client.cc

Ketaki, requesting merge to M-57. Simple change of constant.

This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M57.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b7bced0df9939cde1123d61db9de5c5c169ffe

commit d5b7bced0df9939cde1123d61db9de5c5c169ffe
Author: ihf <ihf@chromium.org>
Date: Tue Feb 28 23:37:17 2017

Chrome OS component updater: UpdateSeverity::LOW

Use UpdateSeverity::LOW icon for Flash updates.

TEST=test_that <ip> desktopui_FlashSanityCheck.download-omaha-component
     See black arrow in grey instead of yellow circle.
BUG= 688532 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2720613007
Cr-Commit-Position: refs/heads/master@{#453540}
(cherry picked from commit 2d0c679aff7cac0b26ca5c3652745db3393a817b)

Review-Url: https://codereview.chromium.org/2720383002
Cr-Commit-Position: refs/branch-heads/2987@{#725}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d5b7bced0df9939cde1123d61db9de5c5c169ffe/chrome/browser/ui/ash/system_tray_client.cc

Lets summarize:
1) Label is not going to be yellow anymore.
2) Bug in  issue 695654  is fixed not causing immediate outdated updates anymore.
3) We will try to be careful when pushing Flash component update initially to stable users and watch their reaction.

Updated 2 hours ago > got yellow arrow after sign out-in.

Version 57.0.2987.85 beta (64-bit)
Platform 9202.43.0 (Official Build) beta-channel auron_yuna
ARC Version 3768718
Firmware Google_Auron_yuna.6301.59.8

Deleted: Screenshot 2017-03-02 at 10.54.39 PM.png 30.4 KB

	Screenshot 2017-03-02 at 10.54.39 PM.png 30.4 KB View Download

Thank you. I pushed the new Flash binary 25.0.0.119 to beta channel using component update two hours ago. The beta channel still has the code yellow button. (It will only turn grey after the next OS update.) Can you check about:components that you are on 25.0.0.119 now?

I am.

Adobe Flash Player - Version: 25.0.0.119
Status - No update
Check for update

Very good.

Notice on stable channel there is a new Flash binary released pretty much every Patch Tuesday. With Component Updater (CU) it can reliably appear that very day to users. Similarly with out of band Flash updates, component update can make them available the fastest way we have available. Sadly it requires a reboot though to take effect, a limitation of the current sandbox. Without CU Flash needs to be bundled with the OS image, which is typically only updated 2-4 times per milestone (6-ish weeks) on stable. There is a trade off between speed and convenience and we are still discussing this.

On dev and beta channel there are experimental Flash binaries built and released once a week or two-ish. But of course there are also weekly OS updates, which means the frequency of updates/reboot requests will go up there if CU is used. So basically for now we are trying to find the right balance to exercise CU on dev/beta while having it ready to be used, if rarely, on stable. (There are automated integration tests, but they did not find everything.)

I am leaning towards using CU on dev channel continuously (sorry, it is for a good cause!), using CU on beta channel about a week before Patch Tuesday (once a month) and using CU on stable channel on Patch Tuesday. First time to use on stable channel will presumably be around April 11th.

ihf@chromium.org, thank you for the explanation.That sounds good to me, now that we know what the yellow arrow means and can explain it to the users on CBC.

Funny, I haven't seen a yellow update in awhile in canary. Makes it hard to see if I can reproduce the icon disappearing after a browser restart.

RE: #c37
I also want to thank you for taking the time to explain what's going on and in a way that we can understand, this is very helpful. 

Perhaps if the update is triggered by the CU for flash or some other component, the UI could simply say something like: 'Restart for component updates.' 

Verified that yellow update icon is not shown anymore. Flash updates display 'Restart to update Adobe Flash Player' message.