New issue
Advanced search Search tips

Issue 688528 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 688520


Participants' hotlists:
blink-rename


Sign in to add a comment

rewrite_to_chrome_style: Need to avoid disruptions to crash analysis

Project Member Reported by lukasza@chromium.org, Feb 3 2017

Issue description

We need to figure out how to avoid disruptions to crash analysis.
 
FWIW, the renaming tool produces auxiliary output that captures the renames:

==== BEGIN TRACKED EDITS ====
../../third_party/WebKit/Source/core/dom/ContainerNode.h:var:siblingAfterChange:sibling_after_change
../../third_party/WebKit/Source/core/dom/Document.h:var:m_xmlVersion:xml_version_
...
../../third_party/WebKit/Source/core/css/CSSPrimitiveValue.h:fun:computeLengthDouble:ComputeLengthDouble
../../third_party/WebKit/Source/core/frame/LocalFrame.h:fun:localFrameRoot:LocalFrameRoot
../../third_party/WebKit/public/platform/WebThread.h:fun:scheduler:Scheduler
==== END TRACKED EDITS ====

Hopefully this can help with the transition somehow.
It's probably also worth pointing out that some renames just change function and method names from camelCaseStyle to PascalCaseStyle, but in some cases we need to change the method name from foo to GetFoo (prepending "Get" prefix to avoid collisions with type names - for more details see the rather long story in  issue 582312 ).

Comment 3 by danakj@chromium.org, Jul 21 2017

Status: WontFix (was: Untriaged)
We determined it would not disrupt things by talking with the crash folks.

Sign in to add a comment