New issue
Advanced search Search tips

Issue 688522 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 578344
issue 688520


Participants' hotlists:
blink-rename


Sign in to add a comment

rewrite_to_chrome_style: Need to adjust method/function names in test (e.g. ASAN) exceptions

Project Member Reported by lukasza@chromium.org, Feb 3 2017

Issue description

After the Great Blink Rename we might need to adjust method/function names in test (e.g. ASAN) exceptions

 
Cc: qyears...@chromium.org
FWIW, I tried searching for non-source-file files in Chromium repo, that mention a method in WTF or blink namespace.  The link below gives 37 hits, but most of them don't seem like something that would need to change after the Great Blink Rename.

https://cs.chromium.org/search/?q=(blink%7CWTF)::.*::+-lang:c%2B%2B+-file:.*%5C.h$+-file:.*/gen/.*+-file:.*%5C.mojom$+-file:.*%5C.mm$&m=100&type=cs

Things that we might want to look into closer:
- third_party/WebKit/Tools/Scripts/webkitpy/common/system/profiler_unittest.py
- third_party/catapult/telemetry/telemetry/internal/testing/perf_report_output.txt
  (it seems okay not to touch this - this has output from one tes run on Thu Aug 15 09:40:36 2013)

Q1: Did I miss anything?  Or do some existing exception files luckily don't mention Blink (or WTF)?

Q2: qyearsley@, could you confirm if profiler_unittest.py is something that should be tweaked during/after the Great Blink Rename?  It seems to me that this test uses mocked inputs, so it should be insulated from the changes done during the Great Blink Rename.
I can confirm that profiler_unittest.py could be tweaked before or after the Rename, but isn't critical because it is insulated from the changes, because the mention of the WTF namespace is just in fake (arbitrary) unit test input.
There are some suppressions in https://cs.chromium.org/chromium/src/tools/valgrind/memcheck/ that I think we'd need to update.

Comment 4 by danakj@chromium.org, Jul 21 2017

Blocking: 578344

Comment 5 by danakj@chromium.org, Jun 27 2018

Status: WontFix (was: Untriaged)
It seems this didn't cause a problem or was done off this bug.

Sign in to add a comment