We should reduce max length.

This is a tricky one.
The current length is 25em, which fit in the cell.
But the words (1 long, 1 short, 1 long, 1 short) make it go on 4 lines, and it does not fit.
Is ther a way to specify Max Length = 3 lines of 9em?

I think we shouldn't release with this bug not fixed so I'm marking it as RBS. 

The phone used in the example has a 4 inch screen. It fits well on 4.7 inch screen (see screenshot). Even if we specify something like "Max Length = 3 lines of 9em" it might not work as this translation is only 3 words (and even three 9-letter words would not fit).

I think we should have a different layout for those screen. Assigning to Amy for ideas.

Deleted: Simulator Screen Shot Feb 6, 2017, 9.10.21 AM.png 67.0 KB

	Simulator Screen Shot Feb 6, 2017, 9.10.21 AM.png 67.0 KB View Download

One way is to have a "Mark" button that brings up an action sheet with "Read", "Unread" and "Cancel" button, similar to what other iOS apps are doing. For example, in Apple Mail try Edit > Mark. 

We could also add a "shrink to fit" property (the font will shrink enough to let the text fill the label). I have attached an example with max 3 lines and shrink to fit.
It is still not the best as the last word is cut.
WDYT? I can also do 2 lines and shrink to fit if you prefer.

Attaching screenshot.

Deleted: Simulator Screen Shot Feb 6, 2017, 2.59.03 PM.png 57.8 KB

	Simulator Screen Shot Feb 6, 2017, 2.59.03 PM.png 57.8 KB View Download

I like the menu idea, but UX wanted one tap actions. And changing the UX because of one  (or few) language may not be the best solution.
I think, if possible, that the best solution would be to have an abbreviated translation. The last word seems pretty long. Is there any way to have a shorter sentence that still sounds natural?

Olivier, I agree with your point about making a large change for one (or few) language issues.

Do we have an example of another translation that doesn't fit? In the overflow perhaps?  If so I think it'd make sense to be consistent either with truncation or shrinking. 

I did not find another translation not fitting. But most of them span on 3 lines on 4" screens.
Attached, a screenshot of a shrink for 2 lines.

I think the best would be to have a solution for M57 then discuss it for M58.

Deleted: Simulator Screen Shot Feb 7, 2017, 9.48.30 AM.png 56.5 KB

	Simulator Screen Shot Feb 7, 2017, 9.48.30 AM.png 56.5 KB View Download

Good examples of other "long" languages like this one are Ukrainian, Thai, Croatian, Polish and Portuguese. Here's a screenshot of Thai.
https://drive.google.com/file/d/0By4O1f2IQqQ_UTMzdFBxdVc0OEk/view

Even on an iPhone 7 though, these languages are abbreviated with ellipses, so I'd like to confirm the ellipses abbreviation makes sense as well. I can confirm Portuguese still makes sense ellipses abbreviated ("Mark all..." is what it translates to which is good), can someone please look at Ukrainian?

The ellipses are part of the sentence (translated from the "Mark all..." in english).
It is here to let the user know that if the button is tapped, an action sheet will be presented with more actions.

Ok sounds good.

Ukrainian translation in 58.0.3005.0 Canary causes layout problems.

Deleted: Reading List Ukr .PNG 73.1 KB

	Reading List Ukr .PNG 73.1 KB View Download

Gauthier: is the screenshot in #18 with "shrink to fit" property added?

No. I have no answer from Amy, I did not land the shrink to fit CL.

OK. I think we should land the shrink to fit CL and see how it is on Canary. If Amy is ok with it we then cherry pick it to M57. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8b621535abb3aa5d9c0ff2196299f1d90449a5

commit 7a8b621535abb3aa5d9c0ff2196299f1d90449a5
Author: gambard <gambard@chromium.org>
Date: Mon Feb 13 13:32:23 2017

Shrink to fit the label on ReadingListToolbar

Shrink the font of the labels in ReadingListToolbar if the label span on more
than 3 lines.

BUG= 688513 

Review-Url: https://codereview.chromium.org/2695693002
Cr-Commit-Position: refs/heads/master@{#449940}

[modify] https://crrev.com/7a8b621535abb3aa5d9c0ff2196299f1d90449a5/ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm

This can be tested in the next canary (shrunk to fit 3 lines).

FWIW: Ukrainian translation still looks the same as it was on screenshot from comment #18. Chrome version: 58.0.3011.0

gambard@ please mark it as fixed if it is the case so that testers can verify it in the next Canary.

re: #13, thanks for checking on other languages. Shrink to fit SGTM since we don't have another precedent. 

merge request for https://codereview.chromium.org/2695693002

This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+ Claude

Just wanted to verify whether this statement is correct: "This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57" ?

The release date for M57 stable is March 14th so I think we have more than 2 weeks to go before AppStore submission. 

Thanks. 

Mardini, the statement is not correct Sorry. I am going to work on having it corrected. It should rather be saying something like we are more than 2 weeks past Branch point and therefore manual review is required. Will keep you posted.

Tested in 58.0.3013.0 canary, iPhone 6S iOS 10.1

Steps:
1. Add an item to reading list
2. Mark item as read
3. Tap on edit
4. Select any of the items.

Observed:
"Mark Unread" is still appearing in 3 lines when in Russian localization.
https://drive.google.com/file/d/0B-tbaGTQZtpQazN4NFFkOUtfemM/view

Yes, the fix was going from 4 lines to 3.
Amy, can you confirm this is the intended behavior?

cmasso: ping merge request. Can you approve it if it is OK for Amy?

Amy, mark the bug as fixed if you approve it.

lgtm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd41122c5e336d84f3c2a34deb64706cae9bdfc

commit fcd41122c5e336d84f3c2a34deb64706cae9bdfc
Author: gambard <gambard@chromium.org>
Date: Mon Feb 20 07:38:30 2017

Shrink to fit the label on ReadingListToolbar

Shrink the font of the labels in ReadingListToolbar if the label span on more
than 3 lines.

BUG= 688513 

Review-Url: https://codereview.chromium.org/2695693002
Cr-Commit-Position: refs/heads/master@{#449940}
(cherry picked from commit 7a8b621535abb3aa5d9c0ff2196299f1d90449a5)

Review-Url: https://codereview.chromium.org/2707753003 .
Cr-Commit-Position: refs/branch-heads/2987@{#595}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fcd41122c5e336d84f3c2a34deb64706cae9bdfc/ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm

Verified on chrome canary version 58.0.3018.0 on iPhone 6s with iOS 10.2.1.  The text in Russian language is displayed in 3 lines.  Looks good.

https://drive.google.com/file/d/0B-tbaGTQZtpQazN4NFFkOUtfemM/view

Verified on chrome beta version 57.0.2987.72 on iPhone 7 plus with iOS 10.2.1.  he text in Russian language is displayed in 3 lines.  Looks good.