New issue
Advanced search Search tips

Issue 688505 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 688503



Sign in to add a comment

cros 1.25x scale: separators

Project Member Reported by est...@chromium.org, Feb 3 2017

Issue description

views::Separators don't always look good at fractional scale. See screenshot, where some of them are blurry.
 
unnamed (4).png
6.5 KB View Download
also see the line below "activate cellular"
image (4).png
30.1 KB View Download
before/after
XCEjFePkjoN.png
32.7 KB View Download
Labels: Proj-MaterialDesign-CrOS
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a3ae74ccfbe8470cd8343ad7e93ed27156171de

commit 4a3ae74ccfbe8470cd8343ad7e93ed27156171de
Author: estade <estade@chromium.org>
Date: Thu Feb 16 20:35:07 2017

views::Separator cleanup.

- Make views::Separators always draw an integral number of pixels (round
  down for fractional scale factors).
- Improve clarity of "size", "horizontal", and "vertical" in
  views::Separator by removing enum and using terms "height" and "width"
- Improve clarity of ash tray constants.

BUG= 688505 

Review-Url: https://codereview.chromium.org/2675983003
Cr-Commit-Position: refs/heads/master@{#451088}

[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/audio/volume_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/special_popup_row.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/user/user_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/first_run/try_chrome_dialog_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ui/views/controls/separator.cc
[modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ui/views/controls/separator.h

Comment 5 by est...@chromium.org, Feb 16 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment