views::Separators don't always look good at fractional scale. See screenshot, where some of them are blurry.
also see the line below "activate cellular"
before/after
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a3ae74ccfbe8470cd8343ad7e93ed27156171de commit 4a3ae74ccfbe8470cd8343ad7e93ed27156171de Author: estade <estade@chromium.org> Date: Thu Feb 16 20:35:07 2017 views::Separator cleanup. - Make views::Separators always draw an integral number of pixels (round down for fractional scale factors). - Improve clarity of "size", "horizontal", and "vertical" in views::Separator by removing enum and using terms "height" and "width" - Improve clarity of ash tray constants. BUG= 688505 Review-Url: https://codereview.chromium.org/2675983003 Cr-Commit-Position: refs/heads/master@{#451088} [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/audio/volume_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/chromeos/palette/palette_tray.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/special_popup_row.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/system_tray_unittest.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_constants.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_constants.h [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_details_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ash/common/system/user/user_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/first_run/try_chrome_dialog_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/content_setting_bubble_contents.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/find_bar_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ui/views/controls/separator.cc [modify] https://crrev.com/4a3ae74ccfbe8470cd8343ad7e93ed27156171de/ui/views/controls/separator.h
Comment 1 by est...@chromium.org
, Feb 3 201730.1 KB
30.1 KB View Download