New issue
Advanced search Search tips

Issue 688495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert StereoPanner tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621

commit b9ef335915c92ee0bc4d6cb6c69bf3d2be021621
Author: rtoy <rtoy@chromium.org>
Date: Wed Feb 22 18:49:21 2017

Convert StereoPanner tests to testharness

The following script was used to convert the tests:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Some manual adjustments needed in stereopanner-testing.js to replace
the calls to testPassed/testFailed.

stereopannernode-basic.html was converted by hand to use testharness
and new Audit.

BUG= 688495 
TEST=stereopannernode-no-glitch.html, stereopannernode-panning.html,
stereopannernode-basic.html

Review-Url: https://codereview.chromium.org/2695113003
Cr-Commit-Position: refs/heads/master@{#452146}

[delete] https://crrev.com/454a93cffb64135a92ba1d8b282be7d1d45f07df/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-basic-expected.txt
[modify] https://crrev.com/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-basic.html
[delete] https://crrev.com/454a93cffb64135a92ba1d8b282be7d1d45f07df/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch-expected.txt
[modify] https://crrev.com/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html
[delete] https://crrev.com/454a93cffb64135a92ba1d8b282be7d1d45f07df/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning-expected.txt
[modify] https://crrev.com/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html
[modify] https://crrev.com/b9ef335915c92ee0bc4d6cb6c69bf3d2be021621/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js

Comment 2 by rtoy@chromium.org, Feb 23 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment