New issue
Advanced search Search tips

Issue 688493 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert ScriptProcessor test to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update test to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5df21df7ccb7b4dcbff0c6d7f8c5f1e1276af31

commit f5df21df7ccb7b4dcbff0c6d7f8c5f1e1276af31
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 17 20:16:51 2017

Convert ScriptProcessor Audit tests to testharness

Converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

BUG= 688493 
TEST=scriptprocessornode-0-output-channels.html

Review-Url: https://codereview.chromium.org/2669263006
Cr-Commit-Position: refs/heads/master@{#451368}

[delete] https://crrev.com/ba507c80f17802f549e814896d505c29b6242942/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt
[modify] https://crrev.com/f5df21df7ccb7b4dcbff0c6d7f8c5f1e1276af31/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3278631c5f14a11be76ad06b91e3125343345cc7

commit 3278631c5f14a11be76ad06b91e3125343345cc7
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 28 22:05:40 2017

Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG= 688493 
TEST=scriptprocessornode.html,
scriptprocessornode-downmix8-2channel-input.html,
scriptprocessornode-upmix2-8channel-input.html,
scriptprocessornode-zero-input-channels.html

Review-Url: https://codereview.chromium.org/2718563004
Cr-Commit-Position: refs/heads/master@{#453717}

[delete] https://crrev.com/c42114c9b3b7bb61deab9879e8b2abe9f4626ef1/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input-expected.txt
[modify] https://crrev.com/3278631c5f14a11be76ad06b91e3125343345cc7/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
[delete] https://crrev.com/c42114c9b3b7bb61deab9879e8b2abe9f4626ef1/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-expected.txt
[delete] https://crrev.com/c42114c9b3b7bb61deab9879e8b2abe9f4626ef1/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input-expected.txt
[modify] https://crrev.com/3278631c5f14a11be76ad06b91e3125343345cc7/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html
[delete] https://crrev.com/c42114c9b3b7bb61deab9879e8b2abe9f4626ef1/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels-expected.txt
[modify] https://crrev.com/3278631c5f14a11be76ad06b91e3125343345cc7/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
[modify] https://crrev.com/3278631c5f14a11be76ad06b91e3125343345cc7/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode.html
[add] https://crrev.com/3278631c5f14a11be76ad06b91e3125343345cc7/third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing-audit.js

Comment 3 by rtoy@chromium.org, Apr 12 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
The two remaining files won't be converted (at least in this round):

scriptprocessornode-detached-no-crash.html
scriptprocessornode-rewrap.html 

Sign in to add a comment