New issue
Advanced search Search tips

Issue 688491 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert PeriodicWave tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eced9c086e9b8bfa1aaa00102b8578fb7e187f40

commit eced9c086e9b8bfa1aaa00102b8578fb7e187f40
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 14 18:58:18 2017

Convert PeriodicWave Audit tests to testharness

Converted tests using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Had to adjust periodicwave-lengths.html manually for uses of
testPassed/testFailed.

BUG= 688491 
TEST=periodicwave-lengths.html, periodicwave-normalization.html

Review-Url: https://codereview.chromium.org/2672093002
Cr-Commit-Position: refs/heads/master@{#450425}

[delete] https://crrev.com/14f63ead450d4014818909b56a183713fd6757ca/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-lengths-expected.txt
[modify] https://crrev.com/eced9c086e9b8bfa1aaa00102b8578fb7e187f40/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-lengths.html
[delete] https://crrev.com/14f63ead450d4014818909b56a183713fd6757ca/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-normalization-expected.txt
[modify] https://crrev.com/eced9c086e9b8bfa1aaa00102b8578fb7e187f40/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-normalization.html

Comment 2 by rtoy@chromium.org, Feb 21 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment