New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688485 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Audit content settings in guest mode

Project Member Reported by steve...@chromium.org, Feb 3 2017

Issue description

From  issue 682107 :

8. Content settings: Some options don't work properly
   * For example, trying to block sites from setting cookies has no
     effect, but it works in Options
   * All these settings need auditing for guest mode

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab4fd5606a3e356af62c45588f2dcf00da8ff77c

commit ab4fd5606a3e356af62c45588f2dcf00da8ff77c
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Feb 08 19:45:11 2017

MD Settings: CrOS: Use correct profile for Guest mode content settings

BUG= 688485 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2679453002
Cr-Commit-Position: refs/heads/master@{#449065}

[modify] https://crrev.com/ab4fd5606a3e356af62c45588f2dcf00da8ff77c/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/ab4fd5606a3e356af62c45588f2dcf00da8ff77c/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

Status: Started (was: Available)
Location: We appear to block all requests in Guest mode, but we show the setting in old/new

Camera/Microphone: Work as expected.
NOTE: If access is granted and then this is "disabled", existing "allow" permissions are preserved. This is functionally useful, but not necessarily intuitive to the user. (The existing Settings behavior is the same).

Notifications: We block all requests by default, however blocked sites show up in the UI as 'blocked' and may be changed to 'allowed' manually. This is the same as the existing behavior.

Javascript: Works as expected.

Images: Works as expected.

Pop-ups: Always blocked, regardless of setting, on both old and new settings. New Settings allows the toggle to change, but the text always correctly says 'Blocked'. We should dsiable the toggle in guest mode.

Background sync: Not sure how to test this.

Automatic downloads: Not sure what this is.

Unsandboxed plugin access: Not sure if this is even relevant for Chrome OS?

Handlers: These appear to be automatically blocked and not changeable.

USB Devices: Inserting a USB stick does not making anything appear, not sure how to test this.

PDF documents: "Open PDFs using a different application" - Probably not relevant.

MIDI devices full control: Section does not show up on Chrome OS at all

Protected Content: Has no effect. Setting is disabled in the 'allow' state on old Settings.


TODO for Guest mode:
* Disable Popups toggle
* Hide PDF documents section on Chrome OS entirely?
* Disable protected content control

To investigate:
* MIDI section
* Testing other sections
* Confirm and disable other UI with no effect

Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-Privacy-ContentSettings
Filed  issue 691711  for missing MIDI section.

* Hide PDF documents section on Chrome OS entirely?
-> "To investigate" which will move to another issue; behavior is consistent with old Settings.

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c0137c32005da3ecfeab84cc6905464af3035c0

commit 7c0137c32005da3ecfeab84cc6905464af3035c0
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Feb 14 20:53:31 2017

MD Settings: Content Settings: Support guest mode.

Specifically, in Guest mode:
* Disable protected content enabled toggles
* Disable the primary toggle for 'popups'
* Hide the protocol-handler section and do not request the default
  value (which triggers a DCHECK).

BUG= 688485 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2689303002
Cr-Commit-Position: refs/heads/master@{#450461}

[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/site_settings/category_default_setting.html
[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/site_settings/category_default_setting.js
[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/7c0137c32005da3ecfeab84cc6905464af3035c0/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Status: Fixed (was: Started)

Sign in to add a comment