New issue
Advanced search Search tips

Issue 688456 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert Panner tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bab2561839d0c280b5490bfbfff6fc1ed4b88eb

commit 6bab2561839d0c280b5490bfbfff6fc1ed4b88eb
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 17 20:10:06 2017

Convert Panner Audit tsets to testharness

Converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Had to adjust the result manually to replace testPassed/testFailed
with Should().summarize().

BUG= 688456 
TEST=panner-automation-basic.html, panner-automation-position.html,
pannernode-basic.html

Review-Url: https://codereview.chromium.org/2676873002
Cr-Commit-Position: refs/heads/master@{#451366}

[delete] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic-expected.txt
[modify] https://crrev.com/6bab2561839d0c280b5490bfbfff6fc1ed4b88eb/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
[delete] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-position-expected.txt
[modify] https://crrev.com/6bab2561839d0c280b5490bfbfff6fc1ed4b88eb/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-position.html
[delete] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic-expected.txt
[modify] https://crrev.com/6bab2561839d0c280b5490bfbfff6fc1ed4b88eb/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b567949e5de163c4e5af1aba7dd1fb645a723d93

commit b567949e5de163c4e5af1aba7dd1fb645a723d93
Author: rtoy <rtoy@chromium.org>
Date: Wed Feb 22 20:39:31 2017

Convert Panner distance model tests to testharness

Manually convert distance model test to use testharness and new Audit.

BUG= 688456 
TEST=distance-*.html

Review-Url: https://codereview.chromium.org/2672863007
Cr-Commit-Position: refs/heads/master@{#452186}

[delete] https://crrev.com/5f994fcb2a75631d75585246c3e11a96d33f52da/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential-expected.txt
[modify] https://crrev.com/b567949e5de163c4e5af1aba7dd1fb645a723d93/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html
[delete] https://crrev.com/5f994fcb2a75631d75585246c3e11a96d33f52da/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse-expected.txt
[modify] https://crrev.com/b567949e5de163c4e5af1aba7dd1fb645a723d93/third_party/WebKit/LayoutTests/webaudio/Panner/distance-inverse.html
[delete] https://crrev.com/5f994fcb2a75631d75585246c3e11a96d33f52da/third_party/WebKit/LayoutTests/webaudio/Panner/distance-linear-expected.txt
[modify] https://crrev.com/b567949e5de163c4e5af1aba7dd1fb645a723d93/third_party/WebKit/LayoutTests/webaudio/Panner/distance-linear.html
[modify] https://crrev.com/b567949e5de163c4e5af1aba7dd1fb645a723d93/third_party/WebKit/LayoutTests/webaudio/resources/distance-model-testing.js

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc4e40323d4c151cd255635396e2af4089b366b

commit fdc4e40323d4c151cd255635396e2af4089b366b
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 24 23:20:28 2017

Convert more PannerNode tests to testharness

Manually convert these PannerNode tests to use testharness and new
Audit.

BUG= 688456 
TEST=panner-automation-equalpower-stereo.html,
panner-equalpower-stereo.html,
panner-equalpower.html,
panner-loop.html

Review-Url: https://codereview.chromium.org/2713943002
Cr-Commit-Position: refs/heads/master@{#452988}

[delete] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo-expected.txt
[modify] https://crrev.com/fdc4e40323d4c151cd255635396e2af4089b366b/third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo.html
[delete] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-expected.txt
[delete] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo-expected.txt
[modify] https://crrev.com/fdc4e40323d4c151cd255635396e2af4089b366b/third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo.html
[modify] https://crrev.com/fdc4e40323d4c151cd255635396e2af4089b366b/third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower.html
[delete] https://crrev.com/264a0dd42bb8612ab0d2d60645e722a7758b013e/third_party/WebKit/LayoutTests/webaudio/Panner/panner-loop-expected.txt
[modify] https://crrev.com/fdc4e40323d4c151cd255635396e2af4089b366b/third_party/WebKit/LayoutTests/webaudio/Panner/panner-loop.html
[modify] https://crrev.com/fdc4e40323d4c151cd255635396e2af4089b366b/third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js

Comment 4 by rtoy@chromium.org, Feb 27 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment