New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688426 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome for Android hangs on returning from home screen

Project Member Reported by amineer@chromium.org, Feb 3 2017

Issue description

Version: Canary, Dev (58.0.3000.3)

From klobag@, I am able to repro as well:

"""Load a page, like cnn.com. Go to Android HOME. Wait for 5 mins. Come back to Chrome Dev. You can't scroll the page. If you have the omnibox, you can interact with menu. You can use tab switcher to kill the tab. But reload doesn't work.

If before you go to HOME, you scroll the page to push omnibox off, you are done with Chrome Dev. You can only kill it from app switcher."""

The last time this occurred in issue 675434 it was traced back to a change to the scheduler and was root caused via new hangs that were detected in Windows.

I reviewed current Windows hangs and notice this is new:

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2758.0.3000.4%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20hang%5D%20blink%3A%3Ascheduler%3A%3ATaskQueueManager%3A%3ADoWork%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports

It correlates to the introduction of https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd

alexclarke@, PTAL.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 3 2017

Labels: merge-merged-3000
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1edf84b63de0519fdfcadd322950db5ffc833657

commit 1edf84b63de0519fdfcadd322950db5ffc833657
Author: Alex Mineer <amineer@chromium.org>
Date: Fri Feb 03 18:03:36 2017

Revert "Dont post delayed DoWork for disabled queues. We could do this for fences too but don't"

This reverts commit 9a8a61516e750796f74869167bb919a05551d4dd.

Speculative revert on branch 3000 only to see if hangs disappear.

BUG= 688426 

Cr-Commit-Position: refs/branch-heads/3000@{#7}
Cr-Branched-From: ed1f2fac6209f8d2e0db3f7dcff38d1e69f5db26-refs/heads/master@{#447669}

[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/1edf84b63de0519fdfcadd322950db5ffc833657/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp

I'm also reverting on ToT since I suspect this bug will not be android specific (assuming that patch is to blame).
We had something similar yesterday with device being idle for sometime. Issue 688090 .
Cc: alexclarke@chromium.org dtu@chromium.org
 Issue 688422  has been merged into this issue.
Issue 688090 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205b4a6222828e70127989c9451bbbd5e56be02d

commit 205b4a6222828e70127989c9451bbbd5e56be02d
Author: alexclarke <alexclarke@chromium.org>
Date: Fri Feb 03 19:30:16 2017

Revert of Dont post delayed DoWork for disabled queues. (patchset #9 id:160001 of https://codereview.chromium.org/2572893002/ )

Reason for revert:
Speculative revert.  Might be causing renderer hangs.

Original issue's description:
> Dont post delayed DoWork for disabled queues. We could do this for fences too but don't
> because that would break the throttling logic which needs to know when the next delayed
> task is due to be run.
>
> BUG= 671669 
>
> Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
> Cr-Original-Commit-Position: refs/heads/master@{#438962}
> Review-Url: https://codereview.chromium.org/2572893002
> Cr-Commit-Position: refs/heads/master@{#447591}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd

TBR=skyostil@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 671669 ,  688426 ,  688422 

Review-Url: https://codereview.chromium.org/2674903003
Cr-Commit-Position: refs/heads/master@{#448046}

[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp

We confirmed that the issue in #0 is no more reproducible in 58.0.3000.6 .
Verified that this issue is fixed on ToT too. Tested on 58.0.3004.0.
Status: Fixed (was: Assigned)
Cc: jbudorick@chromium.org amineer@chromium.org tedc...@chromium.org
 Issue 689790  has been merged into this issue.

Sign in to add a comment