New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688422 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 688426
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

v8.mobile_infinite_scroll-turbo_tbmv2 failing on 7 builders

Project Member Reported by dtu@chromium.org, Feb 3 2017

Issue description

Comment 3 by dtu@chromium.org, Feb 3 2017

Cc: dtu@chromium.org
Looks like one page: tumblr

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : v8.mobile_infinite_scroll_tbmv2
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size_avg/memory:webview:all_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size_avg

Revision             Exit Code      N
chromium@447489      0 +- N/A       1      good
chromium@447506      0 +- N/A       1      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=tumblr v8.mobile_infinite_scroll_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8988659117427378208

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6366720018612224


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: alexclarke@chromium.org
Owner: alexclarke@chromium.org

=== Auto-CCing suspected CL author alexclarke@chromium.org ===

Hi alexclarke@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : alexclarke
  Commit : 9a8a61516e750796f74869167bb919a05551d4dd
  Date   : Wed Feb 01 20:15:04 2017
  Subject: Dont post delayed DoWork for disabled queues. We could do this for fences too but don't

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : v8.mobile_infinite_scroll-turbo_tbmv2
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size_avg/memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size_avg

Revision             Exit Code      N
chromium@447511      0 +- N/A       1      good
chromium@447572      0 +- N/A       1      good
chromium@447587      0 +- N/A       1      good
chromium@447589      0 +- N/A       1      good
chromium@447590      0 +- N/A       1      good
chromium@447591      1 +- N/A       1      bad       <--
chromium@447595      1 +- N/A       1      bad
chromium@447602      1 +- N/A       1      bad
chromium@447632      1 +- N/A       1      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=tumblr v8.mobile_infinite_scroll-turbo_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8988658982518237408

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5208375190618112


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
A revert is already on the CQ.
Mergedinto: 688426
Status: Duplicate (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205b4a6222828e70127989c9451bbbd5e56be02d

commit 205b4a6222828e70127989c9451bbbd5e56be02d
Author: alexclarke <alexclarke@chromium.org>
Date: Fri Feb 03 19:30:16 2017

Revert of Dont post delayed DoWork for disabled queues. (patchset #9 id:160001 of https://codereview.chromium.org/2572893002/ )

Reason for revert:
Speculative revert.  Might be causing renderer hangs.

Original issue's description:
> Dont post delayed DoWork for disabled queues. We could do this for fences too but don't
> because that would break the throttling logic which needs to know when the next delayed
> task is due to be run.
>
> BUG= 671669 
>
> Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
> Cr-Original-Commit-Position: refs/heads/master@{#438962}
> Review-Url: https://codereview.chromium.org/2572893002
> Cr-Commit-Position: refs/heads/master@{#447591}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd

TBR=skyostil@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 671669 ,  688426 ,  688422 

Review-Url: https://codereview.chromium.org/2674903003
Cr-Commit-Position: refs/heads/master@{#448046}

[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/205b4a6222828e70127989c9451bbbd5e56be02d/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4b071b9088980c941d3dea85478b10675a479e6

commit c4b071b9088980c941d3dea85478b10675a479e6
Author: alexclarke <alexclarke@chromium.org>
Date: Wed Feb 15 13:13:51 2017

Dont post delayed DoWork for disabled queues. We could do this for
fences too but don't because that would break the throttling logic
which needs to know when the next delayed task is due to be run.

Contains a fix for the bug which previously was causing renderer hangs.

TaskQueue::GetNextScheduledWakeUp must return base::nullopt for
disabled queues because we no longer schedule wakeups for those. If we
don't do this then the TaskQueueThrottler will be fed misleading data
which causes it to misbehave.

BUG= 671669 ,  688422 

Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
Cr-Original-Original-Commit-Position: refs/heads/master@{#438962}
Review-Url: https://codereview.chromium.org/2572893002
Cr-Original-Commit-Position: refs/heads/master@{#447591}
Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd
Review-Url: https://codereview.chromium.org/2572893002
Cr-Commit-Position: refs/heads/master@{#450679}

[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/c4b071b9088980c941d3dea85478b10675a479e6/third_party/WebKit/public/platform/scheduler/base/task_queue.h

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/469e3d5d1a527c19a07df597399abbe44b85aa0f

commit 469e3d5d1a527c19a07df597399abbe44b85aa0f
Author: alexclarke <alexclarke@chromium.org>
Date: Sat Feb 18 09:44:03 2017

Revert of [Reland] Dont post delayed DoWork for disabled queues. (patchset #14 id:260001 of https://codereview.chromium.org/2572893002/ )

Reason for revert:
Looks like there's still a bad interaction with the TaskQueueThrottler.

https://bugs.chromium.org/p/chromium/issues/detail?id=693672

Original issue's description:
> Dont post delayed DoWork for disabled queues. We could do this for
> fences too but don't because that would break the throttling logic
> which needs to know when the next delayed task is due to be run.
>
> Contains a fix for the bug which previously was causing renderer hangs.
>
> TaskQueue::GetNextScheduledWakeUp must return base::nullopt for
> disabled queues because we no longer schedule wakeups for those. If we
> don't do this then the TaskQueueThrottler will be fed misleading data
> which causes it to misbehave.
>
> BUG= 671669 ,  688422 , 693672
>
> Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
> Cr-Original-Original-Commit-Position: refs/heads/master@{#438962}
> Review-Url: https://codereview.chromium.org/2572893002
> Cr-Original-Commit-Position: refs/heads/master@{#447591}
> Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd
> Review-Url: https://codereview.chromium.org/2572893002
> Cr-Commit-Position: refs/heads/master@{#450679}
> Committed: https://chromium.googlesource.com/chromium/src/+/c4b071b9088980c941d3dea85478b10675a479e6

TBR=skyostil@chromium.org,haraken@chromium.org,altimin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 671669 ,  688422 , 693672

Review-Url: https://codereview.chromium.org/2705703002
Cr-Commit-Position: refs/heads/master@{#451449}

[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/469e3d5d1a527c19a07df597399abbe44b85aa0f/third_party/WebKit/public/platform/scheduler/base/task_queue.h

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f16bd68bd7e191db66f96d2c761017902074d91

commit 2f16bd68bd7e191db66f96d2c761017902074d91
Author: alexclarke <alexclarke@chromium.org>
Date: Tue Feb 21 08:54:13 2017

Dont post delayed DoWork for disabled queues. We could do this for
fences too but don't because that would break the throttling logic
which needs to know when the next delayed task is due to be run.

Contains a fix for the bug which previously was causing renderer hangs.

TaskQueue::GetNextScheduledWakeUp must return base::nullopt for
disabled queues because we no longer schedule wakeups for those. If we
don't do this then the TaskQueueThrottler will be fed misleading data
which causes it to misbehave.

BUG= 671669 ,  688422 , 693672

Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#438962}
Review-Url: https://codereview.chromium.org/2572893002
Cr-Original-Original-Commit-Position: refs/heads/master@{#447591}
Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd
Review-Url: https://codereview.chromium.org/2572893002
Cr-Original-Commit-Position: refs/heads/master@{#450679}
Committed: https://chromium.googlesource.com/chromium/src/+/c4b071b9088980c941d3dea85478b10675a479e6
Review-Url: https://codereview.chromium.org/2572893002
Cr-Commit-Position: refs/heads/master@{#451715}

[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[modify] https://crrev.com/2f16bd68bd7e191db66f96d2c761017902074d91/third_party/WebKit/public/platform/scheduler/base/task_queue.h

Sign in to add a comment