New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688419 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue angleproject:1632



Sign in to add a comment

WebGL 2 conformance tests failing two tests on Windows Intel

Project Member Reported by jmad...@chromium.org, Feb 3 2017

Issue description

Cc: cwallez@chromium.org
Owner: jmad...@chromium.org
I'll triage this on Intel.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/7bb425c64dcd83c60f8253aa1906123fe7804c33

commit 7bb425c64dcd83c60f8253aa1906123fe7804c33
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Feb 03 18:10:51 2017

Revert "D3D11: Clean up blendState code."

This reverts commit 786ad3876730c72311c64cf2f297e671ced847a5.

Reason for revert: 
Seems to have a bug with binding the BlendStates, causing a crash on
Intel.

https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win10%20Release%20%28Intel%20HD%20530%29/141

Failing WebGL 2 tests
WebglConformance_conformance2_reading_read_pixels_from_fbo_test
WebglConformance_deqp_functional_gles3_readpixel

Also generates D3D11 runtime warnings:
D3D11 ERROR: ID3D11DeviceContext::Draw: The renderTarget bound to slot 0 has a format (R8_UINT) that does not support blending. The Pixel Shader output signature indicates this output could be written, and the Blend State indicates blending is enabled for this slot. [ EXECUTION ERROR #376: DEVICE_DRAW_OM_RENDER_TARGET_DOES_NOT_SUPPORT_BLENDING]

BUG= angleproject:1632 
BUG= chromium:688419 

Original change's description:
> D3D11: Clean up blendState code.
> 
> Masked Clear Draw Changes:
> - Use universal blendstate object
> - Eliminate blendState cache for masked clears
> - Use rasterState and scissor rect for scissoring instead of adjusting vertex positions
> - VB contains only static position data (per vertex color removed)
> - Clear color(s) and depth clear values now passed in using a constant buffer
> - MultiColorclear shader used for float clears to workaround alpha rounding issues
> - Update shader compile script and shader source and bytecode headers
> - Remove unused shaders (source and bytecode headers)
> - Use com pointers where possible for D3D11 objects
> 
> BUG= angleproject:1632 
> 
> Change-Id: I98e38451bd453f53b772fe93ec9dcceb4196ea58
> Reviewed-on: https://chromium-review.googlesource.com/413736
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Shahmeer Esmail <shahmeer.esmail@intel.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> 

TBR=geofflang@chromium.org,jmadill@chromium.org,shahmeer.esmail@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= angleproject:1632 

Change-Id: Iea537505d8cce7241edaba1f1d9f404abb1d9a10
Reviewed-on: https://chromium-review.googlesource.com/437306
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearsint11ps.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearfloat11ps.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/CONTRIBUTORS
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearuint11ps.h
[delete] https://crrev.com/604359b9c92113064c5a88d17ea361616a12b3af/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearanytype11vs.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/generate_shaders.bat
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libGLESv2.gypi
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/Clear11.hlsl
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
[add] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearuint11vs.h
[add] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearfloat11vs.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/Clear11.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearfloat11_fl9ps.h
[add] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/clearsint11vs.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/renderer11_utils.h
[modify] https://crrev.com/7bb425c64dcd83c60f8253aa1906123fe7804c33/src/libANGLE/renderer/d3d/d3d11/Clear11.cpp

Blockedon: angleproject:1632
Status: Fixed (was: Assigned)
Thank you for diagnosing this!
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22f8da406c35d6f6579ec86421849063b9cd9bb

commit c22f8da406c35d6f6579ec86421849063b9cd9bb
Author: jmadill <jmadill@chromium.org>
Date: Mon Feb 06 23:58:44 2017

Roll ANGLE ea20d62..34bf2d9

https://chromium.googlesource.com/angle/angle.git/+log/ea20d62..34bf2d9

BUG=667979, chromium:678870 ,  angleproject:1644 , 668223 , chromium:662702 , chromium:688419 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2675413002
Cr-Commit-Position: refs/heads/master@{#448449}

[modify] https://crrev.com/c22f8da406c35d6f6579ec86421849063b9cd9bb/DEPS

Sign in to add a comment