New issue
Advanced search Search tips

Issue 688414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert Oscillator tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update tests to testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3ffab1ea15cbd2c70c84cd785fd14e23052e332

commit c3ffab1ea15cbd2c70c84cd785fd14e23052e332
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 07 19:46:53 2017

Convert Oscillator tests to testharness

Manually convert test to use testharness.

oscillator-basic.html was already using methods from old Audit, so I
didn't change that.  Just updated to testharness.

oscillator-ended.html updated to testharness and new Audit.

Expected result files removed.

BUG= 688414 
TEST=oscillator-basic.html, oscillator-ended.html

Review-Url: https://codereview.chromium.org/2677723002
Cr-Commit-Position: refs/heads/master@{#448702}

[delete] https://crrev.com/23c2f1952f5845194633c1ccd50e7408576c7465/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic-expected.txt
[modify] https://crrev.com/c3ffab1ea15cbd2c70c84cd785fd14e23052e332/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic.html
[delete] https://crrev.com/23c2f1952f5845194633c1ccd50e7408576c7465/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended-expected.txt
[modify] https://crrev.com/c3ffab1ea15cbd2c70c84cd785fd14e23052e332/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693

commit 9a3a1bc17dc95a2a6db144ef66919cc6e1e18693
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 07 23:25:04 2017

Convert Oscillator sweep tests to testharness

Manually converted tests to use testharnees and new Audit.

BUG= 688414 
TEST=osc-*-sweep-snr.html

Review-Url: https://codereview.chromium.org/2675973003
Cr-Commit-Position: refs/heads/master@{#448782}

[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
[delete] https://crrev.com/b64a14bf64e5dc186e75515c1754839f731df15c/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts-expected.txt
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
[modify] https://crrev.com/9a3a1bc17dc95a2a6db144ef66919cc6e1e18693/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/284e8e691ecc8f14c3e3e860dde7adf7081982e8

commit 284e8e691ecc8f14c3e3e860dde7adf7081982e8
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 17 20:06:40 2017

Convert Oscillator Audit tests to testharness

These tests were converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

late-start-testing.js need to be converted manually.

BUG= 688414 
TEST=osc-low-freq.html, osc-negative-freq.html,
oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2672053002
Cr-Commit-Position: refs/heads/master@{#451365}

[delete] https://crrev.com/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq-expected.txt
[modify] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-low-freq.html
[delete] https://crrev.com/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq-expected.txt
[modify] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-negative-freq.html
[delete] https://crrev.com/d9fdf85698a5b75fd3236d9ea9d1faebfcf51242/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start-expected.txt
[modify] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
[modify] https://crrev.com/284e8e691ecc8f14c3e3e860dde7adf7081982e8/third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js

Comment 4 by rtoy@chromium.org, Feb 21 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment