New issue
Advanced search Search tips

Issue 688409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert IIRFilter tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 3 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e94675bc4179ed1555208e39a862a97f0065d62

commit 9e94675bc4179ed1555208e39a862a97f0065d62
Author: rtoy <rtoy@chromium.org>
Date: Fri Feb 10 00:40:37 2017

Convert IIRFilter tests to testharness.

These were converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Some manual changes were needed to convert testPassed/testFailed to
Should().summarize().

Expected results removed since they're not needed.

BUG= 688409 
TEST=iirfilter-basic.html, iirfilter-getFrequencyResponse.html,
iirfilter.html

Review-Url: https://codereview.chromium.org/2676853002
Cr-Commit-Position: refs/heads/master@{#449492}

[delete] https://crrev.com/a4c553be55b1261fd0beda3ea8b527b787ab50a1/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-basic-expected.txt
[modify] https://crrev.com/9e94675bc4179ed1555208e39a862a97f0065d62/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-basic.html
[delete] https://crrev.com/a4c553be55b1261fd0beda3ea8b527b787ab50a1/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-expected.txt
[delete] https://crrev.com/a4c553be55b1261fd0beda3ea8b527b787ab50a1/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse-expected.txt
[modify] https://crrev.com/9e94675bc4179ed1555208e39a862a97f0065d62/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html
[modify] https://crrev.com/9e94675bc4179ed1555208e39a862a97f0065d62/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html

Comment 2 by rtoy@chromium.org, Feb 10 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment