Refactor the view controllers for ReadingList using coordinators.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06742d0d6225a9b04cb79a1204630f9b828cedd2 commit 06742d0d6225a9b04cb79a1204630f9b828cedd2 Author: gambard <gambard@chromium.org> Date: Mon Feb 06 18:54:31 2017 Rename ReadingListViewController to ReadingListCollectionViewController BUG= 688392 Review-Url: https://codereview.chromium.org/2672823003 Cr-Commit-Position: refs/heads/master@{#448329} [modify] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/BUILD.gn [add] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h [rename] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [rename] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm [delete] https://crrev.com/6b10ff77d359100c6fd3e287feccd0342211b51d/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h [modify] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h [modify] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm [modify] https://crrev.com/06742d0d6225a9b04cb79a1204630f9b828cedd2/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea826e787b9356bf03d88dd43045af019270ee7d commit ea826e787b9356bf03d88dd43045af019270ee7d Author: gambard <gambard@chromium.org> Date: Tue Feb 07 10:59:13 2017 Rename ReadingListViewControllerContainer to ReadingListViewController BUG= 688392 Review-Url: https://codereview.chromium.org/2675963002 Cr-Commit-Position: refs/heads/master@{#448592} [modify] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/BUILD.gn [rename] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h [rename] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm [modify] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h [modify] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.mm [rename] https://crrev.com/ea826e787b9356bf03d88dd43045af019270ee7d/ios/chrome/browser/ui/reading_list/reading_list_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6299cc1d8fc24c3fd382b6dbe615a58381b73af0 commit 6299cc1d8fc24c3fd382b6dbe615a58381b73af0 Author: gambard <gambard@chromium.org> Date: Tue Feb 21 13:06:03 2017 Create ReadingListCoordinator This CL creates a ReadingListCoordinator, to manage the ViewController. BUG= 688392 , 693591 Review-Url: https://codereview.chromium.org/2693863005 Cr-Commit-Position: refs/heads/master@{#451747} [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [add] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h [add] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm [rename] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h [modify] https://crrev.com/6299cc1d8fc24c3fd382b6dbe615a58381b73af0/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm [delete] https://crrev.com/ad615573268058885e7e43a15196e5936dc6237f/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h [delete] https://crrev.com/ad615573268058885e7e43a15196e5936dc6237f/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c5ee3cba18800bf7664aaef43afd379e5c9a217 commit 0c5ee3cba18800bf7664aaef43afd379e5c9a217 Author: gambard <gambard@chromium.org> Date: Tue May 16 20:30:13 2017 Move the ReadingListModel in a Mediator The ReadingListMediator will now handle the ReadingListModel instead of passing it directly in the ReadingListCollectionViewController. BUG= 721758 , 688392 Review-Url: https://codereview.chromium.org/2879183002 Cr-Commit-Position: refs/heads/master@{#472205} [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm [modify] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm [add] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_data_sink.h [add] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_data_source.h [add] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_mediator.h [add] https://crrev.com/0c5ee3cba18800bf7664aaef43afd379e5c9a217/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9e02c078fa310d0169787bb7a2187384ee4fc18 commit b9e02c078fa310d0169787bb7a2187384ee4fc18 Author: gambard <gambard@chromium.org> Date: Tue Jun 06 14:29:15 2017 ReadingListDataSource returns items instead of Entries The ReadingListEntry are used in the model. The UI layer should not depend on the ReadingListEntry. This CL move the creation of the ReadingListItems from the view controller to the mediator. BUG= 721758 , 688392 Review-Url: https://codereview.chromium.org/2885383002 Cr-Commit-Position: refs/heads/master@{#477281} [modify] https://crrev.com/b9e02c078fa310d0169787bb7a2187384ee4fc18/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/b9e02c078fa310d0169787bb7a2187384ee4fc18/ios/chrome/browser/ui/reading_list/reading_list_data_source.h [modify] https://crrev.com/b9e02c078fa310d0169787bb7a2187384ee4fc18/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
Comment 1 by bugdroid1@chromium.org
, Feb 6 2017