Issue metadata
Sign in to add a comment
|
Inclusion of site_engagement.mojom-blink.h in Document.h causes occasional build errors |
||||||||||||||||||||||
Issue descriptionInclusion of site_engagement.mojom-blink.h in Document.h causes occasional build errors Chrome Version: OS: OSX What steps will reproduce the problem? (1) Build Chromium and tests (2) (3) What is the expected result? What happens instead? [2017-02-02 12:40:19] In file included from gen/blink/core/testing/InternalDictionary.cpp:15: [2017-02-02 12:40:19] In file included from ../../third_party/WebKit/Source/core/dom/Element.h:33: [2017-02-02 12:40:19] In file included from ../../third_party/WebKit/Source/core/dom/AXObjectCache.h:31: [2017-02-02 12:40:19] >>BUILDBOT>>errors>>compile>> [2017-02-02 12:40:19] ../../third_party/WebKit/Source/core/dom/Document.h:66:10: fatal error: 'public/platform/site_engagement.mojom-blink.h' file not found [2017-02-02 12:40:19] #include "public/platform/site_engagement.mojom-blink.h" [2017-02-02 12:40:19] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [2017-02-02 12:40:19] 1 error generated. A geenrated file is included in Document.h, but a dependency on the generated file is not propagated to users of Document.h. The include can be avoided, since it's included to provide an enum class type that can be forward-declared. Introduced by https://codereview.chromium.org/2535483002 / bug 655415
,
Feb 6 2017
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ca4752e20998b51f7bc1cac9c651db80302bed commit f8ca4752e20998b51f7bc1cac9c651db80302bed Author: tapted <tapted@chromium.org> Date: Mon Feb 06 09:35:30 2017 Forward declare blink::mojom::EngagementLevel in Document.h Similar to https://codereview.chromium.org/2677543003/ but with presubmit fixes. r439726 added a #include for site_engagement.mojom-blink.h to Document.h without adding the necessary public_deps to build files. We can avoid adding more build dependencies to Document.h with a forward declare, so do that. Sheriff landing TBR to fix Pri-0 builder issues. BUG=687707, 688353 , 682986 TBR=sof@chromium.org Review-Url: https://codereview.chromium.org/2677003002 Cr-Commit-Position: refs/heads/master@{#448224} [modify] https://crrev.com/f8ca4752e20998b51f7bc1cac9c651db80302bed/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/f8ca4752e20998b51f7bc1cac9c651db80302bed/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/f8ca4752e20998b51f7bc1cac9c651db80302bed/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dominickn@chromium.org
, Feb 6 2017