New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688331 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-03-21
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Recording overlay gets close after clicking on Clear icon even when recording is ON.

Reported by rk...@etouch.net, Feb 3 2017

Issue description

Chrome Version: 58.0.3000.5 Revision 4ca0a1345c9827247916c391673331b677a3223a-refs/branch-heads/3000@{#6}
OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12), Liunx

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and navigate to Performance section.
(2) Click on Record icon(Recording get started) and then click on Clear icon, observe.

Actual: Recording overlay gets close after clicking on Clear icon even when recording is on.

Expected: Recording overlay should not close after clicking on Clear icon.

This is a regression issue, broken in 'M-57', will soon update the other info:

Good Build: 57.0.2953.0
Bad Build: 57.0.2955.0
 
Actual_Recording.mp4
667 KB View Download
Expected_Recording.mp4
224 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Owner: alph@chromium.org
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2953.0 (Revision: 438989).
Bad build: 57.0.2955.0 (Revision: 439360).

You are probably looking for a change made after 439261 (known good), but no later than 439262 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/8ea98f39401275fda5ee6921092c561ea1e2cae3..dcdca85300f20831c88c0443305004f849e34ea4

From the CL above, assigning the issue to the concern owner

@alph:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2586573002

Note : Able to reproduce the issue in Ubuntu 14.04,Mac 10.12.2 & Win 7.
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 4 by ajha@chromium.org, Feb 13 2017

Cc: pfeldman@chromium.org
Issue is still seen on the latest canary(58.0.3010.0) of Windows-10.

alph@: Could you please take a look at this.
Issue is still seen on mac 10.12.3 with latest canary(58.0.3015.0) 

alph@: Could you please take a look at this.
Just to update!
Issue is still seen on Linux Ubuntu-14.04 with chrome version 58.0.3020.0 
alph@ Could you please take a look at this.

Thanks.

Issue is still seen on mac 10.12.3 with latest canary(58.0.3026.0) 

alph@: Could you please take a look at this and provide the latest update.
Just to update!
Issue is still seen on Windows-7 with chrome version 59.0.3033.0
alph@ Could you please take a look at this.

Thanks.


Issue is still seen on mac 10.12.3 with latest canary(59.0.3041.0) 

alph@: Could you please take a look at this and provide the latest update.





NextAction: 2017-03-21
Your bug is labelled as Stable Release Block, please make sure to land the fix and get it merged into the release branch ASAP.
Just to update the latest behaviour,

Still able to reproduce the issue on Mac 10.12.3 using latest canary #59.0.3053.0.

alph@ - Gentle Ping...!!

Could you please have a look into this issue as it has been marked as a stable blocker.

Thanks...!!
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feb94cb92b94f6cba3a8ba53d1b30c2bd617ae74

commit feb94cb92b94f6cba3a8ba53d1b30c2bd617ae74
Author: alph <alph@chromium.org>
Date: Tue Mar 28 22:39:05 2017

DevTools: disable clear button on Performance panel during recording.

BUG= 688331 

Review-Url: https://codereview.chromium.org/2781973002
Cr-Commit-Position: refs/heads/master@{#460226}

[modify] https://crrev.com/feb94cb92b94f6cba3a8ba53d1b30c2bd617ae74/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Comment 13 by alph@chromium.org, Mar 28 2017

Labels: Merge-Request-58

Comment 14 by alph@chromium.org, Mar 28 2017

Labels: -ReleaseBlock-Stable
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 29 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 29 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a4c42a7ec9ee97a3ab5043e54ccc39d490298c3

commit 7a4c42a7ec9ee97a3ab5043e54ccc39d490298c3
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Mar 29 23:06:31 2017

DevTools: disable clear button on Performance panel during recording.

BUG= 688331 

Review-Url: https://codereview.chromium.org/2781973002
Cr-Commit-Position: refs/heads/master@{#460226}
(cherry picked from commit feb94cb92b94f6cba3a8ba53d1b30c2bd617ae74)

Review-Url: https://codereview.chromium.org/2782333002 .
Cr-Commit-Position: refs/branch-heads/3029@{#483}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7a4c42a7ec9ee97a3ab5043e54ccc39d490298c3/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Comment 17 by alph@chromium.org, Mar 29 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M58 TE-Verified-58.0.3029.54
Tested the issue on windows 7, Ubuntu 14.04 and Mac 10.12.3 using chrome version 58.0.3029.54.Observed that the clear button is disabled during recording on performance panel.
Please find the attached screen cast for the same.
Adding TE-Verified labels.

Thanks,
688331.mp4
467 KB View Download

Sign in to add a comment