New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688310 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[PE] [Suggestions fetcher] Add unit-tests for signed-in state

Project Member Reported by jkrcal@chromium.org, Feb 3 2017

Issue description

Currently, there are no tests for RemoteSuggestionsFetcher that cover sign-in / refresh token / access tokens code.

We should add them.
 

Comment 1 by treib@chromium.org, Feb 3 2017

Labels: zine-client-pe OS-Android
Somewhat related: I recently added an AccessTokenFetcher helper class (components/signin/core/browser/access_token_fetcher.h) that we should use in the fetcher, instead of manually doing the OAuth dance. Would probably be good to have test coverage before changing the implementation :)
The CL that should land soon does not cover the "authentication in progress" case as it requires more changes (instead FakeSigninManagerBase use FakeSigninManager which does not exist on ChromeOS).
(presumably: the AuthInProgress state doesn't actually exist on Android, so adding this unit-test is low-priority)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70957b2671edd5d21ec7b8a6cd36c0cc1f92df99

commit 70957b2671edd5d21ec7b8a6cd36c0cc1f92df99
Author: jkrcal <jkrcal@chromium.org>
Date: Tue Feb 07 10:13:07 2017

[Remote fetcher] Add unit-tests for the authenticated case

This CL adds basic tests for authenticated fetches of
remote_suggestions_fetcher.

BUG= 688310 

Review-Url: https://codereview.chromium.org/2672253003
Cr-Commit-Position: refs/heads/master@{#448581}

[modify] https://crrev.com/70957b2671edd5d21ec7b8a6cd36c0cc1f92df99/components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc

Comment 5 by fi...@chromium.org, Jan 12 2018

Status: WontFix (was: Available)

Sign in to add a comment