Remove logic to subtract status bar from the frame in -[CRWWebController ensureContainerViewCreated] |
|||||
Issue descriptionWe shouldn't be doing it there, but it should be done after verifying that removing the logic doesn't break Chromium.
,
Apr 13 2017
,
Jan 30 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d762728bab96990b6850e1edb2cab49c9cf97a0 commit 5d762728bab96990b6850e1edb2cab49c9cf97a0 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri May 18 08:20:07 2018 Fix Open New Incognito Tab animation This CL fixes the Open New Incognito Tab animation when the BrowserContainerViewController is in fullscreen. It is also fixing the animation for the iPhone X. Bug: 688259, 836730 , 819811, 843931 , 844013 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I298811b90b42122ff2f805f7888d2d5ff750c2b8 Reviewed-on: https://chromium-review.googlesource.com/1061528 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559837} [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/snapshots/snapshot_generator.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.cc [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/chrome/browser/ui/ui_feature_flags.h [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/features.mm [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/public/features.h [modify] https://crrev.com/5d762728bab96990b6850e1edb2cab49c9cf97a0/ios/web/web_state/ui/crw_web_controller.mm
,
Oct 26
,
Oct 26
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by eugene...@chromium.org
, Mar 29 2017Labels: -Pri-2 Pri-3