New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688254 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression: In md-settings, Content Settings sub-page text not appearing properly after changing browser language to French.

Reported by lpa...@etouch.net, Feb 3 2017 
Chrome Version: 58.0.3000.5 (Official Build) 4ca0a1345c9827247916c391673331b677a3223a-refs/branch-heads/3000@{#6}  (64-bit)

OS: Windows(7,8,8.1,10)

Steps to reproduce:
1. Launch Chrome, go to chrome://md-settings, change browser language to French
2. Go to Content Settings in chrome://md-settings and observe.

Actual Result: Content Settings text not appearing properly after changing browser language to French.
Expected Result: Content settings text should appear properly.

This is regression issue broken in 'M 58' and will soon update the bisect info.

Manual Bisect Info: 
Good Build 58.0.2994.0
Bad Build 58.0.2995.0

Note: Issue is not reproducible in MAC and LINUX.
Actual Result.mp4
2.4 MB View Download
Expexted Result.mp4
2.0 MB View Download

Comment 1 by hdodda@chromium.org, Feb 3 2017

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build 58.0.2994.0 (revision : 446546) 
Bad Build 58.0.2995.0 (revision : 446864)

You are probably looking for a change made after 446843 (known good), but no later than 446844 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/50ae54449909cd460dfa06eb4bcef261363e8cb4..e9bb765477ee57a6bee2545dd3eae38b232f547e

From the CL above, assigning the issue to the concern owner 

@dschuyler - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2659833002

Thanks!

Comment 2 by dschuyler@chromium.org, Feb 8 2017

Status: Started (was: Assigned)
CL 2681623002

Comment 3 by dschuyler@chromium.org, Feb 8 2017

Blocking: 671375
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e79f6961d70e8f90eb87ecf355efbb7a55b777c

commit 0e79f6961d70e8f90eb87ecf355efbb7a55b777c
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Feb 14 18:25:32 2017

[i18n] $i18nPolymer to backslash escape

This CL improves security and properly displays i18n strings containing
quotes. This will backslash escape single quotes, double quotes, and
backslashes.

BUG= 688254 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2681623002
Cr-Commit-Position: refs/heads/master@{#450407}

[modify] https://crrev.com/0e79f6961d70e8f90eb87ecf355efbb7a55b777c/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/0e79f6961d70e8f90eb87ecf355efbb7a55b777c/ui/base/template_expressions.cc
[modify] https://crrev.com/0e79f6961d70e8f90eb87ecf355efbb7a55b777c/ui/base/template_expressions_unittest.cc

Comment 5 by dschuyler@chromium.org, Feb 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment