Chrome command line exceeding 8KB in Telemetry tests |
|||||
Issue description
memory.top_10_mobile failing on health-plan-clankium-phone
Doing some local testing, It seems that the health plan bots have recently started passing command lines more than 8KB in size
Traceback (most recent call last):
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 94, in _RunStoryAndProcessErrorIfNeeded
state.RunStory(results)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 299, in RunStory
self._current_page.Run(self)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 108, in Run
shared_state.page_test.RunNavigateSteps(self, current_tab)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py", line 195, in RunNavigateSteps
page.RunNavigateSteps(action_runner)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 117, in RunNavigateSteps
url, script_to_evaluate_on_commit=self.script_to_evaluate_on_commit)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 179, in Navigate
timeout_in_seconds=timeout_in_seconds))
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 58, in _RunAction
action.RunAction(self._tab)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/actions/navigate.py", line 30, in RunAction
tab.WaitForFrameToBeDisplayed()
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 104, in WaitForFrameToBeDisplayed
timeout=timeout)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 209, in WaitForJavaScriptCondition2
return self._inspector_backend.WaitForJavaScriptCondition2(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
return func(*args, **kwargs)
File "/b/build/slave/health-plan-clankium-phone/build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 294, in WaitForJavaScriptCondition2
e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue.
,
Feb 3 2017
What will the fix look like? Increase the limit from within Chrome? Cleanup the number of things we try to pass on the command line? Looks like that tipped the command line over the limit was adding - AlternateComponentUrls to --enable-features - AlternateComponentUrls/AlternateComponentUrls to --force-fieldtrials This is P1 since it prevents us from getting numbers for system health plan
,
Feb 3 2017
Command lines > 8KB in size?! Seriously?! The world has gone mad :)
,
Feb 6 2017
P0 - this has to be fixed ASAP, we're getting a big hole in our measurements for system health reporting.
,
Feb 6 2017
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d2a4f413b7334592963360f8c7f1b1f687919b9 commit 6d2a4f413b7334592963360f8c7f1b1f687919b9 Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Feb 06 22:59:44 2017 Increase the maximum Java command line size This CL increases the maximum Java command line size. The perf bots hit the 8KB limit as a result of additions to testing/variations/fieldtrial_testing_config.json BUG= 688230 TEST=bots green up Review-Url: https://codereview.chromium.org/2675713004 Cr-Commit-Position: refs/heads/master@{#448429} [modify] https://crrev.com/6d2a4f413b7334592963360f8c7f1b1f687919b9/base/android/java/src/org/chromium/base/CommandLine.java
,
Feb 7 2017
Issue 689151 has been merged into this issue.
,
Feb 7 2017
Thanks! This appears to be fixed now.
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/672c3e952db98d1fb73168a8bbd12d84dbf11725 commit 672c3e952db98d1fb73168a8bbd12d84dbf11725 Author: ssid <ssid@chromium.org> Date: Mon Apr 17 18:32:13 2017 Increase the limit of command line file size On a release channel chrome we could have field trials that take upto 10KB of the command line file. Adding browser features on telemetry scripts sometimes take upto 4K. So, increase the limit on command line file size. BUG= 688230 ,708300 Review-Url: https://codereview.chromium.org/2817143002 Cr-Commit-Position: refs/heads/master@{#464956} [modify] https://crrev.com/672c3e952db98d1fb73168a8bbd12d84dbf11725/base/android/java/src/org/chromium/base/CommandLine.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by torne@chromium.org
, Feb 3 2017