New issue
Advanced search Search tips

Issue 688198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

NQE: Do not record correlation if metric is missing

Project Member Reported by tbansal@chromium.org, Feb 3 2017

Issue description

Network quality estimator should not record correlation if any of the underlying metric (http rtt, transport RTT or throughput) is missing. This would ensure that the metric is recorded only when valid values were available, and make it simpler to do the analysis.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d16356dad16ba47a8b708d45aad2f291dabfff

commit 10d16356dad16ba47a8b708d45aad2f291dabfff
Author: tbansal <tbansal@chromium.org>
Date: Fri Feb 03 19:08:17 2017

NQE: Do not record correlation if metric is missing

In Network Quality Estimator (NQE), do not record the correlation
metric if any of the underlying metric is unavailable. Also, do not
record the correlation metric if there was a connection change
recently. These changes ensure that the metric is recorded only when
valid values were available.

BUG= 688198 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668403003
Cr-Commit-Position: refs/heads/master@{#448032}

[modify] https://crrev.com/10d16356dad16ba47a8b708d45aad2f291dabfff/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/10d16356dad16ba47a8b708d45aad2f291dabfff/net/nqe/network_quality_estimator_unittest.cc

Labels: Merge-Request-57 NQE
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98e6ebd04bd475903da59a418b37a39bbe28310

commit b98e6ebd04bd475903da59a418b37a39bbe28310
Author: Tarun Bansal <tbansal@google.com>
Date: Mon Feb 06 18:01:30 2017

NQE: Do not record correlation if metric is missing

In Network Quality Estimator (NQE), do not record the correlation
metric if any of the underlying metric is unavailable. Also, do not
record the correlation metric if there was a connection change
recently. These changes ensure that the metric is recorded only when
valid values were available.

BUG= 688198 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668403003
Cr-Commit-Position: refs/heads/master@{#448032}
(cherry picked from commit 10d16356dad16ba47a8b708d45aad2f291dabfff)

Review-Url: https://codereview.chromium.org/2681483002 .
Cr-Commit-Position: refs/branch-heads/2987@{#333}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b98e6ebd04bd475903da59a418b37a39bbe28310/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/b98e6ebd04bd475903da59a418b37a39bbe28310/net/nqe/network_quality_estimator_unittest.cc

Labels: M-57
Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality
Labels: -nqe

Sign in to add a comment