NQE: Do not record correlation if metric is missing |
|||||||
Issue descriptionNetwork quality estimator should not record correlation if any of the underlying metric (http rtt, transport RTT or throughput) is missing. This would ensure that the metric is recorded only when valid values were available, and make it simpler to do the analysis.
,
Feb 6 2017
,
Feb 6 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b98e6ebd04bd475903da59a418b37a39bbe28310 commit b98e6ebd04bd475903da59a418b37a39bbe28310 Author: Tarun Bansal <tbansal@google.com> Date: Mon Feb 06 18:01:30 2017 NQE: Do not record correlation if metric is missing In Network Quality Estimator (NQE), do not record the correlation metric if any of the underlying metric is unavailable. Also, do not record the correlation metric if there was a connection change recently. These changes ensure that the metric is recorded only when valid values were available. BUG= 688198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2668403003 Cr-Commit-Position: refs/heads/master@{#448032} (cherry picked from commit 10d16356dad16ba47a8b708d45aad2f291dabfff) Review-Url: https://codereview.chromium.org/2681483002 . Cr-Commit-Position: refs/branch-heads/2987@{#333} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/b98e6ebd04bd475903da59a418b37a39bbe28310/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/b98e6ebd04bd475903da59a418b37a39bbe28310/net/nqe/network_quality_estimator_unittest.cc
,
Feb 6 2017
,
Feb 13 2017
,
Feb 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Feb 3 2017