New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 621393



Sign in to add a comment

Fire appinstalled event on Android for WebAPK installation

Project Member Reported by mgiuca@chromium.org, Feb 3 2017

Issue description

The "appinstalled" event fires for a regular app shortcut creation but not WebAPK (due to being a different code path).

We want this functionality in M58.
 
Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
WIP CL: https://codereview.chromium.org/2670963002/

Comment 4 by mgiuca@chromium.org, Apr 24 2017

Cc: dominickn@chromium.org
Status: Fixed (was: Started)
Should be fixed. Needs manual verification on Canary (which I will do), then probably a merge.

Comment 5 by mgiuca@chromium.org, Apr 28 2017

Labels: Merge-Request-59
Verified on Canary. Works, apart from minor  issue 716313 . I think we can proceed to merge this with that bug, and then (optionally) merge the fix to that bug.

Merge rationale: Kind-of a regression (since WebAPKs will go out in M59, it didn't previously matter that this wasn't working on WebAPKs, now it does matter).
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 28 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/689f6f169613b54863f46d2b7d6dd322075b3f55

commit 689f6f169613b54863f46d2b7d6dd322075b3f55
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Apr 28 04:10:26 2017

Android: Fire the appinstalled event on WebAPK installation.

Previously, it would only fire for a shortcut creation (when the app is
not associated with a WebAPK).

BUG= 688178 

Review-Url: https://codereview.chromium.org/2670963002
Cr-Commit-Position: refs/heads/master@{#466580}
(cherry picked from commit 00e4fb83516d445e8952416ed29a481b399a0a24)

Review-Url: https://codereview.chromium.org/2853453002 .
Cr-Commit-Position: refs/branch-heads/3071@{#283}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/689f6f169613b54863f46d2b7d6dd322075b3f55/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/689f6f169613b54863f46d2b7d6dd322075b3f55/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/689f6f169613b54863f46d2b7d6dd322075b3f55/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/689f6f169613b54863f46d2b7d6dd322075b3f55/chrome/browser/banners/app_banner_manager.h

Components: -Manifest Blink>AppManifest
Deprecate (and bulk edit/ move) Manifest

Sign in to add a comment