New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688177 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
steimel@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove mojo Origin <-> string conversions in media_router_bindings.js

Project Member Reported by steimel@chromium.org, Feb 3 2017 
Once the MediaRouter extension is converted to use origin objects instead of strings, remove the conversions between strings and origins from media_router_bindings.js

Comment 1 by sko...@chromium.org, Feb 9 2017

Owner: imch...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by mfo...@chromium.org, May 9 2017 

Can this be done now?  This would be a good fixit task.

Comment 3 by imch...@chromium.org, May 9 2017

Status: Started (was: Assigned)
Yep, I have https://codereview.chromium.org/2869723004/ out for review. The CL to make extension handle mojo Origin objects in the extension is already landed a day ago.
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b6e2e8fb771e659e88885302e1cd83cc6252d68

commit 2b6e2e8fb771e659e88885302e1cd83cc6252d68
Author: imcheng <imcheng@chromium.org>
Date: Wed May 24 22:17:42 2017

[Media Router] Export origin mojom definition to the extension.

Also sends the originMojom.Origin object directly to the extension.
For backwards compatbility, handle origin from the extension as either
a string or Origin object.

BUG= 688177 

Review-Url: https://codereview.chromium.org/2869723004
Cr-Commit-Position: refs/heads/master@{#474442}

[modify] https://crrev.com/2b6e2e8fb771e659e88885302e1cd83cc6252d68/chrome/renderer/resources/extensions/media_router_bindings.js

Comment 5 by imch...@chromium.org, May 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment