New issue
Advanced search Search tips

Issue 688171 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Autofill metrics code gets address/credit card form submissions confused

Project Member Reported by est...@chromium.org, Feb 2 2017

Issue description

Chrome Version: 58.0.3000.0
OS: OS X

If you interact with both an address and a credit card form on a page but only submit one of them, the UMA code records a submission event for both forms.

What steps will reproduce the problem?
(1) Visit http://rsolomakhin.github.io/autofill/ and save some data in the Profile Autofill form (e.g. click one of the Fill Form buttons and submit the form).
(2) Close Chrome, then reopen and visit http://rsolomakhin.github.io/autofill/ again. Focus the Name field in the Profile Autofill form, trigger the autofill dropdown, and select your previously saved profile information. Do *not* submit the form.
(3) Scroll down and press a button to fill in the Credit Card form.
(4) Submit the credit card form.
(5) Open chrome://histograms

What is the expected result?
There is no submitted event in Autofill.FormEvents.Address, since the profile form was not submitted.

What happens instead?
An event is logged for "Submitted with suggestion shown (once)" [19].

If you've interacted with both forms, then the form submission event gets recorded for both, even though only the credit card form was submitted, because both the address and credit card form logger submit events get called unconditionally when any form is submitted. [1]

[1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?l=411

 

Comment 1 by ma...@chromium.org, May 1 2018

Owner: nikunjb@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by dlkumar@google.com, May 1 2018

Cc: dlkumar@google.com

Sign in to add a comment