New issue
Advanced search Search tips

Issue 688155 link

Starred by 3 users
Status: Fixed
Owner:
thakis@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Turn on include sorting for clang-format

Project Member Reported by thakis@chromium.org, Feb 2 2017 
clang-format learned to sort includes long ago. We kept it disabled because reordering includes can break code in pathological situations. Let's try turning it on.

If it does break your code, put newlines between #includes that should not be reordered. clang-format only reorders blocks of consecutive #includes without newlines in between.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16

commit 6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16
Author: thakis <thakis@chromium.org>
Date: Thu Feb 02 23:31:44 2017

Let clang-format sort includes.

After this, `git cl format` will reorder includes in blocks of #includes
that are not separated by newlines.

This works in almost all cases, but it can break some code e.g.

  #include <windows.h>
  #include <shellapi.h>

clang-format will reorder these now, but shellapi.h only compiles if
windows.h was included first. Relying on this is brittle, so replace
code like this with

  #include <windows.h>

  // Must be after windows.h:
  #include <shellapi.h>

Since clang-format doesn't reorder across blocks, this will do the right
thing.

This also means you're still on the hook of putting blocks with user headers,
C++ headers, and C headers in the right order.

This will hopefully replace src/tools/sort-headers.py which contains
some hacky heuristics -- but just inserting newlines between includes
when needed (with a comment) seems like a better tradeoff anyhow.
And the automatic integration with `git cl format` is nice.

(clang-format has IncludeIsMainRegex and IncludeCategories for adding
heuristics, but we shouldn't use these, they're too complicated.)

BUG= 688155 
TBR=brettw

Review-Url: https://codereview.chromium.org/2669263003
Cr-Commit-Position: refs/heads/master@{#447875}

[modify] https://crrev.com/6b08b5d1106a7faa33f2dbb8c07ac9ba67058e16/.clang-format

Comment 2 by thakis@chromium.org, Feb 3 2017 

Done, but let's keep this open for a while until we decide we want to keep this. If you add newlines to pacify clang-format, please put BUG= 688155  on those CLs.

Comment 3 by dcheng@chromium.org, Feb 3 2017 

clang-format header sorting can cause problems for Blink. The Blink presubmit requires that system headers in <> come after user headers in "", but clang-format defaults to the opposite.

This wouldn't be a problem but it looks like there are some number of Blink files that don't separate these blocks with a newline currently (see the random changes in LocalDOMWindow.{cpp,h} in https://codereview.chromium.org/2668753006/).

If we want to default to this ordering everywhere, we should probably just kill the Blink presubmit for this.

Comment 4 by thakis@chromium.org, Feb 3 2017

Labels: -OS-Windows OS-All

Comment 5 by thakis@chromium.org, Feb 3 2017 

https://codereview.chromium.org/2667423006/ disables the test. I'll wait a bit if anyone on blink-dev hsa concerns before I tick cq+
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f3583163a9592f26a0b72ff702eee5d9b5f0378

commit 9f3583163a9592f26a0b72ff702eee5d9b5f0378
Author: thakis <thakis@chromium.org>
Date: Fri Feb 03 21:36:52 2017

blink: Remove include ordering checks, clang-format does this now.

One change in behavior: clang-format wants <> includes to go first
(like in Chromium -- but Chromium style recommends a newline between the
<> include block and the "" include block), while they used to go to the
end in Blink.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2667423006
Cr-Commit-Position: refs/heads/master@{#448074}

[modify] https://crrev.com/9f3583163a9592f26a0b72ff702eee5d9b5f0378/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/9f3583163a9592f26a0b72ff702eee5d9b5f0378/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dc1852220e72a4d6c62495db7481239dbbd4375

commit 0dc1852220e72a4d6c62495db7481239dbbd4375
Author: dcheng <dcheng@chromium.org>
Date: Tue Feb 14 17:46:00 2017

Add v8 to Blink DEPS.

Now that clang-format sorts includes, v8 should be included as a user
header (using double quotes) instead of a system header (with angle
brackets). However, this means DEPS will now check for v8, so explicitly
allow it in Blink DEPS.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2697813002
Cr-Commit-Position: refs/heads/master@{#450399}

[modify] https://crrev.com/0dc1852220e72a4d6c62495db7481239dbbd4375/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/0dc1852220e72a4d6c62495db7481239dbbd4375/third_party/WebKit/Source/platform/wtf/DEPS
[modify] https://crrev.com/0dc1852220e72a4d6c62495db7481239dbbd4375/third_party/WebKit/Source/wtf/DEPS
[modify] https://crrev.com/0dc1852220e72a4d6c62495db7481239dbbd4375/third_party/WebKit/public/DEPS
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5739d00dd6cd1c4c4126bc9053b0a9905549711

commit e5739d00dd6cd1c4c4126bc9053b0a9905549711
Author: dcheng <dcheng@chromium.org>
Date: Mon Feb 27 10:53:24 2017

//third_party/WebKit/Source/web: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2719893002
Cr-Commit-Position: refs/heads/master@{#453184}

[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/SuspendableScriptExecutor.h
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/WebCryptoNormalize.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/WebTestingSupport.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/tests/RunAllTests.cpp
[modify] https://crrev.com/e5739d00dd6cd1c4c4126bc9053b0a9905549711/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a6450fb88ac73ce0eea958f97e6c304011d1caa

commit 7a6450fb88ac73ce0eea958f97e6c304011d1caa
Author: dcheng <dcheng@chromium.org>
Date: Mon Feb 27 11:03:34 2017

//third_party/WebKit/Source/modules: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2715233002
Cr-Commit-Position: refs/heads/master@{#453185}

[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumer.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.h
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp
[modify] https://crrev.com/7a6450fb88ac73ce0eea958f97e6c304011d1caa/third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7

commit b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7
Author: dcheng <dcheng@chromium.org>
Date: Mon Feb 27 11:26:09 2017

//third_party/WebKit/Source/core: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2718023002
Cr-Commit-Position: refs/heads/master@{#453190}

[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/animation/AnimationTestHelper.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/animation/EffectInputTest.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/dom/DOMTypedArray.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/events/ErrorEvent.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/plugins/BUILD.gn
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/plugins/PluginView.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/streams/ReadableStreamController.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/streams/ReadableStreamOperations.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/testing/GCObservation.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/timing/MemoryInfo.cpp
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/b9e58094ba5883ab20514b21bffdb9fa6ac0c0e7/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/60991f990b2ec0efe57668c499091695ac416f39

commit 60991f990b2ec0efe57668c499091695ac416f39
Author: Daniel Cheng <dcheng@chromium.org>
Date: Mon Feb 27 16:05:46 2017

Don't use DCHECK in v8-util.h.

This will randomly break compilation units that don't happen to #define
DCHECK before v8-util.h is included.

BUG= chromium:688155 

Change-Id: I7abdaf87c8bb7aca995d9e6e7ef8b4faff0dc50c
Reviewed-on: https://chromium-review.googlesource.com/447002
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43455}
[modify] https://crrev.com/60991f990b2ec0efe57668c499091695ac416f39/include/v8-util.h
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43cf179651d67978fa112f436b17359a688a321e

commit 43cf179651d67978fa112f436b17359a688a321e
Author: dcheng <dcheng@chromium.org>
Date: Tue Feb 28 00:24:49 2017

//third_party/WebKit/Source/bindings: include v8 as a user, not system, header

Note: due to an issue with v8's GN files, files that use include v8
inspector headers are being skipped for now.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2721533003
Cr-Commit-Position: refs/heads/master@{#453409}

[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ArrayValue.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/Dictionary.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/IDLDictionaryBase.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/Microtask.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/NativeValueTraits.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/RetainedObjectInfo.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptController.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptState.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptString.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/SharedPersistent.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/ToV8.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/UseCounterCallback.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8CrossOriginSetterInfo.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8EventListener.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8GCController.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8Initializer.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8IteratorResultValue.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
[modify] https://crrev.com/43cf179651d67978fa112f436b17359a688a321e/third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 2 2017

Labels: merge-merged-5.8
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/40008aa5dfaea16a4c0086733e5dab9a1312f98f

commit 40008aa5dfaea16a4c0086733e5dab9a1312f98f
Author: Michael Hablich <hablich@chromium.org>
Date: Thu Mar 02 11:54:51 2017

Merged: Don't use DCHECK in v8-util.h.

Revision: 60991f990b2ec0efe57668c499091695ac416f39

BUG= chromium:688155 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2725883003 .
Cr-Commit-Position: refs/branch-heads/5.8@{#4}
Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429}

[modify] https://crrev.com/40008aa5dfaea16a4c0086733e5dab9a1312f98f/include/v8-util.h
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/98d03583ca17ba46e1950fcc5a121831d5e198cc

commit 98d03583ca17ba46e1950fcc5a121831d5e198cc
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Mar 07 10:28:00 2017

Add inspector headers to top-level v8 target if inspector is enabled.

Otherwise, v8 embedders need to depend on targets in src.

BUG= chromium:688155 

Change-Id: Idea90d8f550cd4d0141b92a7bdd18f4df664d11b
Reviewed-on: https://chromium-review.googlesource.com/447845
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43631}
[modify] https://crrev.com/98d03583ca17ba46e1950fcc5a121831d5e198cc/BUILD.gn

Comment 16 by thakis@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)
Looks like we're pretty happy with this!
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550aa3df793999b28a48c0bbc1694ffe0203b15c

commit 550aa3df793999b28a48c0bbc1694ffe0203b15c
Author: thakis <thakis@chromium.org>
Date: Wed Jun 28 20:41:30 2017

Stop checking include order in PRESUBMIT.py

Nowadays, clang-format checks for this already.

BUG= 688155 

Review-Url: https://codereview.chromium.org/2957353002
Cr-Commit-Position: refs/heads/master@{#483125}

[modify] https://crrev.com/550aa3df793999b28a48c0bbc1694ffe0203b15c/PRESUBMIT.py
[modify] https://crrev.com/550aa3df793999b28a48c0bbc1694ffe0203b15c/PRESUBMIT_test.py
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3948d7d90243a7c42664c4153c7b79c47a340b20

commit 3948d7d90243a7c42664c4153c7b79c47a340b20
Author: Adam Rice <ricea@chromium.org>
Date: Fri Jun 29 13:25:06 2018

Stop using #include <v8.h> from Blink

Replace the remaining 7 uses of #include <v8.h> in Blink with the modern-
style #include "v8/include/v8.h".

Bug:  688155 

Change-Id: I6b28c0f94275f9e461fedf68d48edc1ebd7c7b74
Reviewed-on: https://chromium-review.googlesource.com/1119951
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571455}
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/modules/payments/payment_request_respond_with_observer.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/modules/serviceworkers/fetch_respond_with_observer.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/modules/serviceworkers/respond_with_observer.cc
[modify] https://crrev.com/3948d7d90243a7c42664c4153c7b79c47a340b20/third_party/blink/renderer/platform/heap/thread_state.cc
►

Sign in to add a comment