Instrument memory usage of net/disk_cache/blockfile/ |
|||
Issue descriptionThe general idea is to have a "size_t EstimateMemoryUsage() const" method for every non-trivial class in net/disk_cache/blockfile. The member method should return the size of dynamically allocated memory in bytes (see more info in base/trace_event/memory_usage_estimator.h) Then the memory usage can be hooked up in net/'s MemoryDumpProvider (see URLRequestContext::OnMemoryDump() or HttpNetworkSession::DumpMemoryStats()). An example to do this can be found crrev.com/2661333002 or b4199f82689fd146d52d8352f4d07bd79d6cfbd6.
,
Feb 3 2017
This is filed as a follow-up for [Instrumenting SimpleCache] https://codereview.chromium.org/2661333002/. The concern brought up by pasko@ and other reviewers is that if we only have a part of codebase instrumented, it might cause confusion. But I agree this is of low priority because blockfile is being deprecated.
,
Mar 12 2018
Archived due to lack of activity |
|||
►
Sign in to add a comment |
|||
Comment 1 by mmenke@chromium.org
, Feb 3 2017