New issue
Advanced search Search tips

Issue 688137 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: [regression] The developer console seems to show conflicting values

Reported by venkat22...@gmail.com, Feb 2 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce the problem:
1. In JavaScript, create an object that will be set by the view.

For example:
Object objA = { name: 'name' }

View will set this object as { name: 'nameOne' } on any event (Let us assume click).

2. When I console log the object, the object shows up the stale value { name: 'Name' } when it is collapsed. But, when I expand the Object shown in the console, it shows the correct value: { name: 'NameOne' }.

Seems like the expanded view is the latest value and the collapsed view is stale.

What is the expected behavior?
The expanded and collapsed views should show the latest object.

What went wrong?
The expanded and collapsed views are not in sync.

Did this work before? N/A 

Chrome version: 55.0.2883.95  Channel: stable
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 24.0 r0

 
Labels: ReleaseBlock-Stable M-57
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: DevTools: [regression] The developer console seems to show conflicting values (was: The developer console seems to show conflicting values)
The problem here is that the snapshot value (collapsed) is shown the same way as expanded. It used to have a different style. It also should not disappear when I expand actual values.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8e815220afc20f198f0b513cb46edc2d823186

commit 9d8e815220afc20f198f0b513cb46edc2d823186
Author: luoe <luoe@chromium.org>
Date: Fri Feb 03 04:30:31 2017

DevTools: restore the style of expandable titles on console object previews

This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.

Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002

Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003

BUG= 688137 

Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}

[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-call-getter-on-proto-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/9d8e815220afc20f198f0b513cb46edc2d823186/third_party/WebKit/Source/devtools/front_end/console/consoleView.css

Comment 3 by l...@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Status: Fixed (was: Assigned)
The style has been reverted, and the change has made it to Canary.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M57 branch 2987 before 5:00 PM PT, Monday (02/06/) so we can pick it up for next Beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8accd71b9931b2e71fca9b0b823e381872ebb5

commit 9b8accd71b9931b2e71fca9b0b823e381872ebb5
Author: luoe <luoe@chromium.org>
Date: Mon Feb 06 18:29:13 2017

DevTools: restore the style of expandable titles on console object previews

This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.

Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002

Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003

BUG= 688137 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}
(cherry picked from commit 9d8e815220afc20f198f0b513cb46edc2d823186)

Review-Url: https://codereview.chromium.org/2674243004
Cr-Commit-Position: refs/branch-heads/2987@{#335}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-call-getter-on-proto-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/9b8accd71b9931b2e71fca9b0b823e381872ebb5/third_party/WebKit/Source/devtools/front_end/console/consoleView.css

Comment 7 by l...@chromium.org, Feb 6 2017

Cc: l...@chromium.org
 Issue 689194  has been merged into this issue.

Comment 8 by l...@chromium.org, Feb 10 2017

 Issue 690113  has been merged into this issue.
Cc: rbasuvula@chromium.org
 Issue 843603  has been merged into this issue.

Sign in to add a comment