Issue metadata
Sign in to add a comment
|
Select mode of items in Autofill or Passwords detail view have no accessibility label for the "Select" checkbox |
||||||||||||||||||||||
Issue descriptionApp Version: 58.0.2991.0 iOS Version: iOS 10.3 Device: iPhone 7 URL: Steps to reproduce: 1. Save a password or autofill profile in Chrome for iOS 2. Open Settings ->Saved Passwords or Settings->Autofill 3. Turn on Voice Over for the device 4. Double tap home to go back to Chrome via app switcher 5. Double tap EDIT in the top right 6. Tap the round checkbox or select circle to the right of your save password or autofill profile. Observed results: The username and URL of the saved password is spoken, or the name of the saved autofill profile is spoken. Expected results: While speaking the username and URL or name of the autofill profile is helpful, there is no spoken indication of the "unselected" select status of the checkbox, or that this is a checkbox the user can select in general. Once we "check" or "select" the box by double tapping it, "Selected" is spoken in addition to the identifying parameters, which is good, but we need to solve for this initial status where it should be speaking something along the lines of "Unselected" or "Unchecked". Number of times you were able to reproduce: 5/5 Bug reproducible after clean install:Yes Bug reproducible after clearing cache and cookies:Yes Observed behavior in Chrome Mobile on Android: n/a Check for similar behavior on Firefox/Safari: n/a Bug reproducible on current stable build (App Version, iOS Version): Yes M57 Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes M56
,
Feb 3 2017
,
Mar 15 2017
I propose an accessibility hint: "Double tap to select password.".
,
Mar 15 2017
I wanted to add support in MDC but they don't implement Accessibility correctly natively, so I will implement it like the rest of our support with cells: in our code.
,
Mar 15 2017
So actually it might be possible to add support in MDC. The thing is that I need to had two strings and they don't have a reliable translation process. I suspect this won't make M58. I file https://github.com/material-components/material-components-ios/issues/1257 for MDC to implement a string translation process. In the meantime I will add new strings on our side and implement a workaround downstream on several different cells.
,
Mar 15 2017
Note that History is in a similar situation but the accessibility support there is better as it supports custom actions.
,
Mar 16 2017
Adding an accessibility hint in our code is not possible as I need the information that the cell is selectable, which is internal to the MDC class. So I made a PR to MDC: https://github.com/material-components/material-components-ios/pull/1258 The new strings will need to be translated with their process, but I don't think they have one yet.
,
Mar 21 2017
PR was merged: https://github.com/material-components/material-components-ios/pull/1258 Need to wait for next MDC release (circa tomorrow). Then I'll check on Canary and request merging to 58 branch.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01de990dd9de1747f7c7c59a1e664e11933f66ad commit 01de990dd9de1747f7c7c59a1e664e11933f66ad Author: lpromero <lpromero@chromium.org> Date: Thu Mar 23 16:06:43 2017 Use MDC CollectionCells bundle. BUG=688096 R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2756193003 Cr-Commit-Position: refs/heads/master@{#459103} [modify] https://crrev.com/01de990dd9de1747f7c7c59a1e664e11933f66ad/ios/third_party/material_components_ios/BUILD.gn
,
Mar 27 2017
,
Apr 18 2017
Waiting for translations: https://github.com/material-components/material-components-ios/issues/1259
,
Apr 18 2017
Trying for 59.
,
Apr 21 2017
We branched and we don't yet have the translations from the MDC side.
,
Apr 21 2017
,
Jun 20 2017
Still no news from MDC regarding the translation of the strings.
,
Jan 27 2018
,
May 1 2018
,
Sep 27
,
Nov 29
vabr going hobby only -> reducing involvement. Please contact me directly in urgent matters. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by olivierrobin@chromium.org
, Feb 3 2017Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)