[DIAL] DialFetchDeviceDescriptionFunction not destroyed after responding |
|||||
Issue descriptionThis is due to a circular dependency between the function and the DeviceDescriptionFetcher that it owns.
,
Feb 3 2017
Need to verify when in canary. After that we will request merge to 57.
,
Feb 3 2017
Verified on mac canary 58.0.3001.0
,
Feb 3 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b656c780b62f5bca1465324360c2be28ee73deca commit b656c780b62f5bca1465324360c2be28ee73deca Author: Derek Cheng <imcheng@chromium.org> Date: Fri Feb 03 22:48:04 2017 [DIAL] Break circular dependency in DialFetchDeviceDescriptionFunction. DeviceDescriptionFetcher has 2 references (in the 2 calbacks) to the DialFetchDeviceDescriptionFunction that owns it, but only 1 of the 2 references is removed at the end state. This results in a circular dependency which prevents the function from being destroyed. This patch manually destroys the DeviceDescriptionFetcher after the fetching is done to break the circular dependency. BUG= 688089 Review-Url: https://codereview.chromium.org/2668383004 Cr-Commit-Position: refs/heads/master@{#447857} (cherry picked from commit d8033dadec98c7c2f4c407f89c128b166b5922ef) Review-Url: https://codereview.chromium.org/2674573011 . Cr-Commit-Position: refs/branch-heads/2987@{#304} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/b656c780b62f5bca1465324360c2be28ee73deca/chrome/browser/extensions/api/dial/dial_api.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 2 2017