New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688089 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[DIAL] DialFetchDeviceDescriptionFunction not destroyed after responding

Project Member Reported by imch...@chromium.org, Feb 2 2017

Issue description

This is due to a circular dependency between the function and the DeviceDescriptionFetcher that it owns.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8033dadec98c7c2f4c407f89c128b166b5922ef

commit d8033dadec98c7c2f4c407f89c128b166b5922ef
Author: imcheng <imcheng@chromium.org>
Date: Thu Feb 02 22:19:48 2017

[DIAL] Break circular dependency in DialFetchDeviceDescriptionFunction.

DeviceDescriptionFetcher has 2 references (in the 2 calbacks) to the
DialFetchDeviceDescriptionFunction that owns it, but only 1 of the 2
references is removed at the end state. This results in a circular
dependency which prevents the function from being destroyed. This patch
manually destroys the DeviceDescriptionFetcher after the fetching is
done to break the circular dependency.

BUG= 688089 

Review-Url: https://codereview.chromium.org/2668383004
Cr-Commit-Position: refs/heads/master@{#447857}

[modify] https://crrev.com/d8033dadec98c7c2f4c407f89c128b166b5922ef/chrome/browser/extensions/api/dial/dial_api.cc

Cc: dbbrooks@chromium.org
Status: Fixed (was: Started)
Need to verify when in canary. After that we will request merge to 57.
Labels: Merge-Request-57
Status: Verified (was: Fixed)
Verified on mac canary 58.0.3001.0
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b656c780b62f5bca1465324360c2be28ee73deca

commit b656c780b62f5bca1465324360c2be28ee73deca
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Feb 03 22:48:04 2017

[DIAL] Break circular dependency in DialFetchDeviceDescriptionFunction.

DeviceDescriptionFetcher has 2 references (in the 2 calbacks) to the
DialFetchDeviceDescriptionFunction that owns it, but only 1 of the 2
references is removed at the end state. This results in a circular
dependency which prevents the function from being destroyed. This patch
manually destroys the DeviceDescriptionFetcher after the fetching is
done to break the circular dependency.

BUG= 688089 

Review-Url: https://codereview.chromium.org/2668383004
Cr-Commit-Position: refs/heads/master@{#447857}
(cherry picked from commit d8033dadec98c7c2f4c407f89c128b166b5922ef)

Review-Url: https://codereview.chromium.org/2674573011 .
Cr-Commit-Position: refs/branch-heads/2987@{#304}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b656c780b62f5bca1465324360c2be28ee73deca/chrome/browser/extensions/api/dial/dial_api.cc

Sign in to add a comment