New issue
Advanced search Search tips

Issue 688073 link

Starred by 1 user
Status: WontFix
Owner:
tandrii@chromium.org
Closed: Feb 2017
Cc:
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CQ does not use results of dry run

Project Member Reported by no...@chromium.org, Feb 2 2017 
I ran a dry run on
https://codereview.chromium.org/2663023004/#ps40001
and got a green build: https://luci-milo.appspot.com/swarming/task/3418ed75cf75ca10

Then I clicked CQ button to commit the CL and CQ started a new build.

Why didn't it reuse the previous result?

CQ status:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663023004/40001

Comment 1 by tandrii@chromium.org, Feb 2 2017

Owner: tandrii@chromium.org
Status: WontFix (was: Untriaged)
WAI: it's presubmit builder, which is treated specially. if you look at properties, the presubmit gets "dry_run" set during dry run, which instructs PRESUBMIT to bypass OWNERS checks in most projects.

Comment 2 by no...@chromium.org, Feb 2 2017 

i see

Comment 3 by tandrii@chromium.org, Feb 2 2017 

In other words, in an ideal world luci-py would get its own recipe which would execute actual python tests, while PRESUBMIT would be doing last-minute checks like OWNERS.
►

Sign in to add a comment