New issue
Advanced search Search tips

Issue 688063 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Use proper names for fakes, mocks, or stubs classes and files in ios/web/public/test/fakes

Project Member Reported by eugene...@chromium.org, Feb 2 2017

Issue description

All classes are prefixed with Test, which in most cases actually mean "Fake"
 

Comment 1 by pkl@chromium.org, Mar 11 2017

Labels: Hotlist-GoodFirstBug
Cc: pinkerton@chromium.org
Would this mean also re-naming all the files to match the class? 
Summary: Use proper names for fakes, mocks, or stubs classes and files in ios/web/public/test/fakes (was: Use proper names for fakes, mocks, or stubs classes in ios/web/public/test/fakes)
pinkerton@, yes
Labels: -Type-Feature Type-Task
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d20a96abc5584eff170e6ab1088084a0f35e3b1e

commit d20a96abc5584eff170e6ab1088084a0f35e3b1e
Author: Eugene But <eugenebut@google.com>
Date: Sat Nov 11 01:55:58 2017

Use Fake name instead of Test for ios/web/test/fakes classes.

Bug: 688063
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If9b10b4e9ab8b975dbce21aec6cf287ef82a6ab9
Reviewed-on: https://chromium-review.googlesource.com/759301
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515788}
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/navigation/crw_session_controller_unittest.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/navigation/navigation_manager_util_unittest.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/net/crw_ssl_status_updater_unittest.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/test/fakes/BUILD.gn
[rename] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/test/fakes/crw_fake_back_forward_list.h
[rename] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/test/fakes/crw_fake_back_forward_list.mm
[rename] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/test/fakes/fake_navigation_manager_delegate.h
[add] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/test/fakes/fake_navigation_manager_delegate.mm
[delete] https://crrev.com/43f17057cc88b7c1ee868cb288d6681b2eb708b2/ios/web/test/fakes/test_navigation_manager_delegate.mm
[modify] https://crrev.com/d20a96abc5584eff170e6ab1088084a0f35e3b1e/ios/web/web_state/ui/crw_web_controller_unittest.mm

Cc: mrefaat@chromium.org
Components: Mobile>iOSWeb
Components: -Mobile>WebView>Glue
Components: -Mobile>iOSWeb Mobile>iOSWeb>PublicAPI

Sign in to add a comment